-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date.parse() not working with milliseconds #3980
Labels
Milestone
Comments
chakrabot
pushed a commit
that referenced
this issue
Nov 21, 2017
…econds (Fix #3980) Merge pull request #3988 from xiaoyinl:Date_parse_ms As reported in #3980, `Date.parse()` doesn't recongize the format `YYYY-MM-DD HH:mm:ss.sss`. This PR updates `DateImplementation::UtcTimeFromStrCore()` to correctly parse this format which is supported by other engines. Fixes #3980
dilijev
added a commit
to dilijev/ChakraCore
that referenced
this issue
Jan 12, 2018
… Date parse implementation. See: * [ 30082da ] 2017-11-21 17:57 doilij@m.. [1.8>master] [MERGE chakra-core#4067 @xiaoyinl] Make Date.to(UTC)String() outputs match web reality and spec language * [ 03db098 ] 2017-11-21 14:58 doilij@m.. [1.8>master] [MERGE chakra-core#3988 @xiaoyinl] Make Date.parse() support milliseconds (Fix chakra-core#3980) * [ afc6789 ] 2017-10-26 19:19 doilij@m.. [MERGE chakra-core#4062 @xiaoyinl] treat two digit years less than 50 as 21st century years Related: Issue chakra-core#4543: Refactor test parseISO.js to increase test coverage
chakrabot
pushed a commit
that referenced
this issue
Jan 13, 2018
…e for recent changes to Date parse implementation. Merge pull request #4544 from dilijev:Bug15077412-parseISO See: * [ 30082da ] 2017-11-21 17:57 doilij@m.. [1.8>master] [MERGE #4067 @xiaoyinl] Make Date.to(UTC)String() outputs match web reality and spec language * [ 03db098 ] 2017-11-21 14:58 doilij@m.. [1.8>master] [MERGE #3988 @xiaoyinl] Make Date.parse() support milliseconds (Fix #3980) * [ afc6789 ] 2017-10-26 19:19 doilij@m.. [MERGE #4062 @xiaoyinl] treat two digit years less than 50 as 21st century years Related: Issue #4543: Refactor test parseISO.js to increase test coverage
chakrabot
pushed a commit
that referenced
this issue
Jan 13, 2018
…seISO.baseline for recent changes to Date parse implementation. Merge pull request #4544 from dilijev:Bug15077412-parseISO See: * [ 30082da ] 2017-11-21 17:57 doilij@m.. [1.8>master] [MERGE #4067 @xiaoyinl] Make Date.to(UTC)String() outputs match web reality and spec language * [ 03db098 ] 2017-11-21 14:58 doilij@m.. [1.8>master] [MERGE #3988 @xiaoyinl] Make Date.parse() support milliseconds (Fix #3980) * [ afc6789 ] 2017-10-26 19:19 doilij@m.. [MERGE #4062 @xiaoyinl] treat two digit years less than 50 as 21st century years Related: Issue #4543: Refactor test parseISO.js to increase test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Calling
Date.parse()
with the formatYYYY-MM-DD HH:mm:ss.sss
returnsNaN
:Date.parse('2017-10-17 08:00:00.000')
I'm not sure whether the specification requires this format, but it works in Chrome and Firefox.
Tested in Edge 40.15063.674.0
The text was updated successfully, but these errors were encountered: