-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test parseISO.js to increase test coverage #4543
Comments
dilijev
added a commit
to dilijev/ChakraCore
that referenced
this issue
Jan 12, 2018
… Date parse implementation. See: * [ 30082da ] 2017-11-21 17:57 doilij@m.. [1.8>master] [MERGE chakra-core#4067 @xiaoyinl] Make Date.to(UTC)String() outputs match web reality and spec language * [ 03db098 ] 2017-11-21 14:58 doilij@m.. [1.8>master] [MERGE chakra-core#3988 @xiaoyinl] Make Date.parse() support milliseconds (Fix chakra-core#3980) * [ afc6789 ] 2017-10-26 19:19 doilij@m.. [MERGE chakra-core#4062 @xiaoyinl] treat two digit years less than 50 as 21st century years Related: Issue chakra-core#4543: Refactor test parseISO.js to increase test coverage
chakrabot
pushed a commit
that referenced
this issue
Jan 13, 2018
…e for recent changes to Date parse implementation. Merge pull request #4544 from dilijev:Bug15077412-parseISO See: * [ 30082da ] 2017-11-21 17:57 doilij@m.. [1.8>master] [MERGE #4067 @xiaoyinl] Make Date.to(UTC)String() outputs match web reality and spec language * [ 03db098 ] 2017-11-21 14:58 doilij@m.. [1.8>master] [MERGE #3988 @xiaoyinl] Make Date.parse() support milliseconds (Fix #3980) * [ afc6789 ] 2017-10-26 19:19 doilij@m.. [MERGE #4062 @xiaoyinl] treat two digit years less than 50 as 21st century years Related: Issue #4543: Refactor test parseISO.js to increase test coverage
chakrabot
pushed a commit
that referenced
this issue
Jan 13, 2018
…seISO.baseline for recent changes to Date parse implementation. Merge pull request #4544 from dilijev:Bug15077412-parseISO See: * [ 30082da ] 2017-11-21 17:57 doilij@m.. [1.8>master] [MERGE #4067 @xiaoyinl] Make Date.to(UTC)String() outputs match web reality and spec language * [ 03db098 ] 2017-11-21 14:58 doilij@m.. [1.8>master] [MERGE #3988 @xiaoyinl] Make Date.parse() support milliseconds (Fix #3980) * [ afc6789 ] 2017-10-26 19:19 doilij@m.. [MERGE #4062 @xiaoyinl] treat two digit years less than 50 as 21st century years Related: Issue #4543: Refactor test parseISO.js to increase test coverage
chakrabot
pushed a commit
that referenced
this issue
Jan 30, 2018
Merge pull request #4602 from xiaoyinl:date_test_refactor This PR splits `parseISO.js` into two files `parseValidISO.js` and `parseInvalidISO.js`. Unfortunately they still have to be tagged exclude_jenkins,exclude_xplat, because of time zone and negative years. But it now takes 2.4 seconds for `parseValidISO.js` to complete. Is this enough to remove the `Slow` tag? Fixes #4543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
test\Date\parseISO.js contains a lot of test cases (and generates a lot of output) and thus is tagged Slow. Unfortunately it is also excluded from Jenkins and xplat for various reasons (timezone and negative years):
Thus, this test is only run in Nightlies and perhaps doesn't get the attention it deserves. This test could be split into 3 tests: timezone-sensitive, negative years, and everything else. Perhaps at that time it will not be meaningfully slow and we can remove the Slow tag, enabling these tests in more test configurations.
As for the Slow tag:
This test takes 4 seconds to run on my machine, which probably means it will run for a concerning amount of time on CI VMs. Hopefully, when the test is split into parts it will be faster.
The text was updated successfully, but these errors were encountered: