Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf revisions no longer reports EXPERIMENTAL notice [v7] #3060

Conversation

chinigo
Copy link
Contributor

@chinigo chinigo commented Jul 29, 2024

Description of the Change

This commit changes the cf revision and cf revisions commands to no longer print a notice that the command is experimental.

Why Is This PR Valuable?

The cf revision and cf revisions commands were introduced over 4 years ago and are no longer experimental.

Applicable Issues

n/a

How Urgent Is The Change?

Not urgent.

Other Relevant Parties

None

Related PRs

@chinigo chinigo marked this pull request as ready for review July 29, 2024 18:42
@a-b a-b force-pushed the 187923330-no-longer-mark-revisions-experimental-v7 branch from f3ba47c to c77a48b Compare August 1, 2024 20:58
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question [blocking]: I'm questioning if these types of changes belong to V7, as V7 is at the end of its lifecycle. My understanding is that V7 receives security and bug fixes, while behavior changes belong to V8 and main (future V9).

@joaopapereira
Copy link
Contributor

Since it is removing the Experimental warning, I am not sure we can consider this a new feature, it is more housekeeping now.

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the test was there to ensure that the message was present I do not think these tests make sense anymore.
If you come back to the code and see this test, it is strange 😄

@a-b
Copy link
Member

a-b commented Aug 2, 2024

@joaopapereira I did not say anything about a new feature. Removing EXPERIMENTAL from the cli output is a change to the output.

@chinigo chinigo force-pushed the 187923330-no-longer-mark-revisions-experimental-v7 branch from c77a48b to a115b7a Compare August 5, 2024 17:50
@chinigo
Copy link
Contributor Author

chinigo commented Aug 5, 2024

  • Negative test assertions removed (including one whole file that contained nothing but).
  • Moved the revisions and revision command into the APPS section of the cf help output.

@chinigo chinigo force-pushed the 187923330-no-longer-mark-revisions-experimental-v7 branch from a115b7a to 276007c Compare August 13, 2024 15:41
@chinigo
Copy link
Contributor Author

chinigo commented Aug 13, 2024

Updated PR to incorporate @Samze's feedback on the main version of this PR:

  • cf revision remains in EXPERIMENTAL status.
  • cf revisions is no longer in EXPERIMENTAL status.
  • cf rollback is no longer in EXPERIMENTAL status.

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaopapereira joaopapereira merged commit 358cf56 into cloudfoundry:v7 Aug 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants