Run make localnet-start in CI and ensure network reaches at least 10 blocks #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added tests for Delegator Validators routes * Updated tests for undelegations * Updated Gaia-lite docs * Updated PENDING.md * Updated comments * Deleted more comments * Add spacing
If dep already sees its scratch directory (.vendor-new), dep ensure fails. This rm -rf's that directory so make get_vendor_deps doesn't fail.
* changelog * ... * decimal func working * decimal complete, untested * fixing tests * decimal compile errors resolved * test compile errors * precision multiplier test * 1% laptop battery * fixed TestNewDecFromStr * equalities working * fix bankers round chop * ... * working, some decimal issues resolved * fix rounding error * rounding works * decimal works * ... * deleted rational * rational conversion working * revert changelog * code compiles (not tests) * went through all NewDec, made sure they were converted from NewRat properly * test debugging * all testing bugs besides the json marshalling fixed * json unmarshal * lint * document update * fix lcd test * cli test fix * mostly undo Dece -> Rate * val comments * Efficiency improvements This now caches all of the precision multipliers (as they were all used in non-mutative functions), and caches the precisionInt calculation. (Now it just copies the already calculated value) * Cache another precisionInt() call. * Improve banker rounding efficiency * remove defer, make negation in-place. * chris val comments * bez comments * Aditya comments * ... * val comments * rebasing start * ... * compiling * tests pass * cli fix * anton, cwgoes, val comments * val and jae comments * type * undo reuse quo
This is done by making the function mutative. A non-mutative variant is created for functions that depend on it being non-mutative.
Using the addresses in Bech32 form
… x/stake commands * Handle panic gracefully when unbond begin fails See #1831 * Handle failure to query delegation gracefully. Closes #1907 * Update PENDING.md * Reuse stake's error functions * New ErrBadValidatorAddr error UnmarshalValidator() checks the address length first; it does not make sense to attempt unmarshalling if the address is wrong. * New ErrBadDelegationAddr error * Introduce ErrBad{Redelegation,UnbondingDelegation}Addr custom errors to replace errors.New() calls * Replace ErrBadUnbondingDelegationAddr with ErrBadDelegationAddr to avoid duplication Thanks: @melekes for pointing this out * Use sdk.AddrLen instead of hardcoded address length * s/triple/tuple/ ## mention PR id in PENDING.md
Codecov Report
@@ Coverage Diff @@
## release/v0.24.0 #2057 +/- ##
===================================================
+ Coverage 63.81% 64.86% +1.05%
===================================================
Files 113 115 +2
Lines 6665 6863 +198
===================================================
+ Hits 4253 4452 +199
+ Misses 2129 2127 -2
- Partials 283 284 +1 |
|
The localnet command is failing on the nondeterminism issue: |
|
And passing after I |
|
If you instead target this against the release branch and rebase you don't need to cherry-pick the fix. Alternatively we can wait until we merge the release back into develop. This process definitely needs work... |
|
Great idea @jackzampolin |
|
Why did we close this? |
|
Sorry -- I'm not sure how I closed this? Fat fingered 🤷♂️ |
jackzampolin
force-pushed
the
jack/ci-localnet
branch
from
8bf7e85
to
869a7ed
Compare
|
Well @alexanderbez you were right on this. |
|
Closing in favor of #2067 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/)PENDING.mdthat include links to the relevant issue or PR that most accurately describes the change.For Admin Use: