[release/7.0] Fix encoding problem when publishing with AOT #89388
Conversation
ilonatommy
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #83035 to release/7.0. Customer Impact Testing Risk
|
|
The failure is not connected. |
| [BuildAndRun(host: RunHost.Chrome, aot: true, config: "Debug")] | ||
| public void BuildThenPublishWithAOT(BuildArgs buildArgs, RunHost host, string id) | ||
| [BuildAndRun(host: RunHost.Chrome, aot: true, config: "Release", testUnicode: false)] | ||
| [BuildAndRun(host: RunHost.Chrome, aot: true, config: "Debug", testUnicode: false)] |
There was a problem hiding this comment.
Looks like you are missing the corresponding changes to BuildAndRunAttribute?
|
Friendly reminder: if you want this servicing fix to be included in the September 2023 Release, you'll have to merge this PR before August 14th. |
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #83510 to release/7.0.
Customer Impact
Customers had a problem with publishing applications with AOT that were located in a project named with Unicode chars. It was because we were using internally the assembly name directly to paste into C code. We were only replacing a few chosen characters with underscored. Now we are replacing all non-ASCII chars with underscores, to avoid throwing an error in the C code.
Testing
Creating a project that has non-ASCII chars in the name and publish with AOT on.
Risk
Low, this only makes a previously failing use case work now.