Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync 6.x to master220412 + Fixed OSGI Shell #23901

Merged
merged 67 commits into from
Apr 13, 2022
Merged

Sync 6.x to master220412 + Fixed OSGI Shell #23901

merged 67 commits into from
Apr 13, 2022

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Apr 13, 2022

  • in 00bbae0 I broke the OSGI Shell, but in this branch was no test for that
  • the test was resuscitated in 6.x branch, so when I tried do sync into master it detected the bug.

dmatej and others added 30 commits March 30, 2022 14:15
@dmatej
Issue eclipse-ee4j#23507 nucleus-tests rebased to glassfish.zip and e…
5ced771 
…nabled

Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
Issue eclipse-ee4j#23507 nucleus-tests moved to appserver admin tests
57a66d9
@hs536
Integrate Jersey 3.0.4
e302871 
Signed-off-by: hs536 <sawamura.hiroki@fujitsu.com>
@hs536
Resolve conflicts
3480a7c 
Signed-off-by: hs536 <sawamura.hiroki@fujitsu.com>
@dmatej
eclipse-ee4j#23507 Fixed admin-tests
f7901c4 
- now they detect bugs, see next commits
- 2 tests are reproducers of bugs I could not fix easily
- new test dependency - ShrinkWrap

Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
Replacing broken ra.xml - the one in openmq 6.2.0 is invalid
87243bd 
- breaks connector 1.5 xsd
- See eclipse-ee4j/openmq#1432
@dmatej
Fixed Pattern constraint validator messages
d2d04c4 
- Pattern uses {jakarta.validation.constraints.Pattern.message} by default

Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
Optimization in GetHabitatInfo command
4090e1e
@dmatej
Fixed error processing around JMS Destination admin commands
e08d842 
- errors were swallowed, so I saw just HTTP 500 without any info neither
  in response nor in server.log
@dmatej
Fixed saving of temporary files (uploaded when deploying)
dbae2da 
- previous state caused an unsupported archive exception
@dmatej
Random cleanups
8c29a78 
- note one FIXME when server tries to used Jersey Client which is not on classpath
@arjantijms
Merge pull request eclipse-ee4j#23886 from hs536/jersey304
00492b4 
Integrate Jersey 3.0.4
@dmatej
Refactoring in admin-tests
c95fa71 
- separation - jersey/asadmin/url
- shutdownHook
- set of rest clients targeting usage, less confusion
@dmatej
ClientWrapper is Closeable now
86ae3a9
@dmatej
Renamed package to org.glassfish.main.admin.test.rest
5662e66
@arjantijms
Merge pull request eclipse-ee4j#23889 from dmatej/nucleus-tests-6.x
2be7140 
eclipse-ee4j#23507 Nucleus tests transformed to Admin tests
@dmatej
eclipse-ee4j#23507 Forgotten junit4 usage in forgotten module -> junit5
698fff0
@dmatej
Tiny updates
7415633 
- several comments
- link to JDK11 javadoc instead of 8
@dmatej
Updated maven plugins
0c34473
@dmatej
Take care about white space
cac3629 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: David Matějček <dmatej@seznam.cz>
@hs536 @dmatej
Remove empty volumeMounts
8248152 
Signed-off-by: hs536 <sawamura.hiroki@fujitsu.com>
@dmatej
Updated HK2 from 3.0.2 to 3.0.3
23ca958
@dmatej
eclipse-ee4j#23507 Removed usage of deprecated methods in tests
aa384a1
@arjantijms @dmatej
Fixes 16587 - support custom principal in Jakarta Authentication
939774f 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@dmatej
Updated checkstyle dependency
259f5cf
@arjantijms @dmatej
Removed removed parameter
50b8628 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@dmatej
Fixed compatibility of OpenDJ with JDK17
ee32672 
- separated OpenDJ setup and start - setup sets JVM options (add-exports!)
- always using fresh unzipped OpenDJ
- also more robust path processing
- better JVM settings
@dmatej
Cleanup cherrypick to 6.x
7541f0a 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
Fixed imports of RequestFacade
ff4c62b
@dmatej
TCK cleanup
d50705a 
- better choose artifact than thousand profiles
- more consistent
- tck tests are not executed by default, but added to the reactor when
  the tck profile is activated.
@dmatej
Random cleanups
1407e96 
- note one FIXME when server tries to used Jersey Client which is not on classpath
@dmatej
Refactoring in admin-tests
2c3af69 
- separation - jersey/asadmin/url
- shutdownHook
- set of rest clients targeting usage, less confusion
@dmatej
ClientWrapper is Closeable now
be9368b
@dmatej
Renamed package to org.glassfish.main.admin.test.rest
e3f2e2f
@dmatej
eclipse-ee4j#23507 Forgotten junit4 usage in forgotten module -> junit5
e99fcbf
@dmatej
Tiny updates
edfa046 
- several comments
- link to JDK11 javadoc instead of 8

# Conflicts:
#	nucleus/parent/pom.xml
@dmatej
Updated maven plugins
3db1a6b 
# Conflicts:
#	nucleus/parent/pom.xml
#	nucleus/pom.xml
@dmatej
TCK cleanup
cc9eb2e 
- better choose artifact than thousand profiles
- more consistent
- tck tests are not executed by default, but added to the reactor when
  the tck profile is activated.

# Conflicts:
#	appserver/tests/tck/tck-download/jakarta-authentication-tck/pom.xml
#	appserver/tests/tck/tck-download/jakarta-authorization-tck/pom.xml
#	appserver/tests/tck/tck-download/jakarta-faces-tck/pom.xml
#	appserver/tests/tck/tck-download/jakarta-rest-tck/pom.xml
#	appserver/tests/tck/tck-download/pom.xml
@dmatej
Stabilized admin-tests
11ed0f3 
- stop-removefiles-start principle replaced by asadmin commands (junit extension)
- discovery: detached jobs don't survive restarting domain, synchronous do.

Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej
mvn package should pass after mvn clean install -Pfastest -T4C too
2a670f1 
- processing annotations of generated classes moved to own execution as
  the current compiler plugin supports that
@dmatej
Updated >project< artifact to 1.0.7
3d3e961 
# Conflicts:
#	pom.xml
@dmatej
RestModelExtensionProcessor class cleanup
32b2a41
@dmatej
Fixed build_re_dev used on Eclipse's Jenkins
1be299b 
- respecting MVN_EXTRA
@dmatej
Removed enforcer versions (inherited)
4215016 
# Conflicts:
#	pom.xml
@dmatej
Merge remote-tracking branch 'eclipse/6.x' into sync-6.x-to-master220412
2497c55
@dmatej
eclipse-ee4j#23507 Using glassfish7 directory name
c1f51c0
@dmatej
Updated Readme.txt
9f43a95 
- nucleus tests are gone -> moved to appserver
- 3.6.0 as minimum
@dmatej
Improved failing OSGiCommandsITest
7510041
@dmatej
AdminMain now can print stacktraces
85e5290 
- required to set env AS_TRACE=true in the asadmin shell first
@dmatej
Parser - just a quick cleanup and nicer NPE message
559f4ba
@dmatej
Logging errors in RemoteCommands as severe, not as finer
b865744
@dmatej
Fixed OSGI Shell broken in 00bbae0
9742548 
- optional packages, not provided - they serve as an alternative
- cleanup
- without previous commit it was impossible to find the bug - in fact there
  were two:
  - enhanceForTarget originally returned it's parameter, not null
  - inaccessible imports

Signed-off-by: David Matějček <dmatej@seznam.cz>
@dmatej dmatej requested a review from arjantijms April 13, 2022 22:29
@dmatej dmatej self-assigned this Apr 13, 2022
@dmatej dmatej added this to the 7.0.0 milestone Apr 13, 2022
@dmatej dmatej marked this pull request as ready for review April 13, 2022 22:40
@arjantijms
Copy link
Contributor

Thanks!

@arjantijms arjantijms merged commit efde5f5 into eclipse-ee4j:master Apr 13, 2022
@dmatej dmatej deleted the sync-6.x-to-master220412 branch April 14, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees

@dmatej dmatej

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dmatej @arjantijms @hs536