Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Allow to add custom settings to the grid settings popover #7077

Closed
jughosta opened this issue Aug 14, 2023 · 5 comments · Fixed by #7190
Closed

[EuiDataGrid] Allow to add custom settings to the grid settings popover #7077

jughosta opened this issue Aug 14, 2023 · 5 comments · Fixed by #7190
Labels
data grid feature request help wanted The EUI team is looking for community members to pick up and implement this issue

Comments

@jughosta
Copy link
Contributor

Screenshot 2023-08-14 at 15 32 29

Is your feature request related to a problem? Please describe.
We would like to provide more grid configuration options to our users. For example, a configuration for the sample size (how many rows should be loaded). In the future it could also be to show/hide field type tokens etc.

Describe the solution you'd like
@ninoslavmiskovic and @andreadelrio are suggesting to add the sample size configuration to the existing grid settings popover.

Describe alternatives you've considered
We also considered to use a separate popover but the UI starts to be cluttered with icon buttons.

Additional context
elastic/kibana#157269

@JasonStoltz JasonStoltz added the help wanted The EUI team is looking for community members to pick up and implement this issue label Aug 14, 2023
@github-actions
Copy link

👋 Thank you for your suggestion or request! While the EUI team agrees that it's valid, it's unlikely that we will prioritize this issue on our roadmap. We'll leave the issue open if you or anyone else in the community wants to implement it by contributing to EUI. If not, this issue will auto close in one year.

@kertal
Copy link
Member

kertal commented Aug 31, 2023

Closing in favor of #7077 which will bring a more holistic solution

@kertal
Copy link
Member

kertal commented Aug 31, 2023

Oh, I cannot close, help!

@cee-chen
Copy link
Member

cee-chen commented Aug 31, 2023

Closing in favor of #7147

@cee-chen
Copy link
Member

cee-chen commented Sep 5, 2023

Re-closing with the not-planned status (rather than the complete status) for internal tracking, apologies for the noise 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data grid feature request help wanted The EUI team is looking for community members to pick up and implement this issue
Projects
None yet
4 participants