Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate Maps: auto fit data bounds #2054

Closed
dadoonet opened this issue Nov 28, 2014 · 17 comments · Fixed by #72129
Closed

Coordinate Maps: auto fit data bounds #2054

dadoonet opened this issue Nov 28, 2014 · 17 comments · Fixed by #72129
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result Feature:Coordinate Map

Comments

@dadoonet
Copy link
Member

It would be awesome to have a new settings for the tile maps panel which auto fit the map to data bounds.

When I create a tile maps and split the map based on a terms aggregation, each time I reopen the dashboard, each map is using the "first map settings" to display data.

As I am aggregating by country code, I have to click on the auto fit button on each map. Here is the automatic rendering I'd like to have.

kibana

@peterskim12
Copy link

+1

@jmleoni
Copy link

jmleoni commented Jan 7, 2015

I like this one too :-)

@quasipedia
Copy link

👍

@jmleoni
Copy link

jmleoni commented Jan 21, 2015

I just issued a pull request to fix this. #2708

@quasipedia
Copy link

@jmleoni - Good on you! I just hold a presentation of Kibana to colleagues and they all start laughing when I had to reload the page and clicking like a mad dog all over the 9 maps on the dashboard! ...at least it was entertaining! ;) 👍

@junwei-wang
Copy link

what's going on with this issue?

@jmleoni
Copy link

jmleoni commented Mar 11, 2015

Right now it my fix works, but is not being merged because it lacks automated tests.
see comments on #2970

@quasipedia
Copy link

@jmleoni - A bit off-topic, and maybe it's just a language thing (English is not my first language!), but I hope you are not suggesting "lack of tests" is a minor flow in a piece of code...

Code without tests for me equals "proof of concept" quality level and I'm happy the policy around here is no-tests, no-merge! :)

More on topic: thanks for having come up with a fix for this!! 😄 🎆 👍 👏

@jmleoni
Copy link

jmleoni commented Mar 11, 2015

@quasipedia I totally agree with you. The problem is the tile_maps widget (which I didn't author but which I intend to contribute to) lacks any automated tests. I'd be happy to add a test for my added feature if there was any test suite already in place.

@igorgatis
Copy link

I'd love this feature. I wonder how long it takes to appear in Found once pulled.

@berglh
Copy link

berglh commented Aug 10, 2016

I'm super surprised this is still an issue, would be great to get it resolved. @jmleoni Is the automated test for the tile maps widget still an issue?

@tbragin tbragin added Feature:Coordinate Map Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Nov 1, 2016
@jmleoni
Copy link

jmleoni commented Jan 10, 2017

@berglh At the time I was asked by the kibana team to write an automated test, there weren't any for the map widgets. Now automated tests are implemented but I never had the leisure to spend a couple of hours on issue an updated PR with my fix on master.

@alexfrancoeur alexfrancoeur added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Feb 6, 2018
@timroes timroes removed the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Apr 11, 2018
@alexfrancoeur
Copy link

@thomasneirynck I believe this is the functionality I was looking for in our slack discussion. This feature would be particularly useful for reporting.

Expected:
screen shot 2018-07-24 at 11 50 26 am

Actual:
screen shot 2018-07-24 at 11 52 01 am

@alexfrancoeur alexfrancoeur changed the title Tile Maps: auto fit data bounds Coordinate Maps: auto fit data bounds Jul 24, 2018
@thomasneirynck
Copy link
Contributor

We are working on a new implementation of map visualizations and are not planning to add any new features to the existing implementation. We will take this suggestion under consideration for the new app.

@Tishinator
Copy link

+1

@nreese nreese added enhancement New value added to drive a business result and removed release_note:enhancement labels Feb 28, 2019
@lukeelmers lukeelmers added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 27, 2020
@nreese nreese self-assigned this May 13, 2020
@thomasneirynck
Copy link
Contributor

Closing this as dupe of #53831. This enhancement would be added to the Maps-app, and not the coordinate map visualization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation enhancement New value added to drive a business result Feature:Coordinate Map
Projects
None yet