Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto zoom TileMap to the Feature layer area upon loading #2970

Closed
wants to merge 1 commit into from
Closed

Auto zoom TileMap to the Feature layer area upon loading #2970

wants to merge 1 commit into from

Conversation

jmleoni
Copy link

@jmleoni jmleoni commented Feb 10, 2015

WIP need to fix tests

Fixing styling typos

Adding config option for autozoom

Fixes #2054

WIP need to fix tests

Fixing styling typos

Adding config option for autozoom
@jmleoni jmleoni mentioned this pull request Feb 10, 2015
@rashidkpc rashidkpc changed the title Fixes #2054 : Auto zoom TileMap to the Feature layer area upon loading Auto zoom TileMap to the Feature layer area upon loading Feb 10, 2015
@jmleoni
Copy link
Author

jmleoni commented Feb 10, 2015

I just had an other go on this one. I hope it can fit in the the next release !

@rashidkpc
Copy link
Contributor

I like the idea here, but I'd want to see tests here. @jthomassie, can you work with @jmleoni to get some tests around this functionality?

@jmleoni
Copy link
Author

jmleoni commented Mar 11, 2015

@jthomassie do you have an idea on how to test this ? As of now, it doesn't seem that there is any test suite for the tile_map widget. I'd be happy to contribute to test my added feature when the suite is bootstrapped.

@jthomassie
Copy link

@jmleoni yes, working on some refactoring and tests for tile maps. will have a PR submitted very soon.

@jthomassie
Copy link

@jmleoni tests for tile map are now in master, along with several other changes.
Please take a look, and let me know if you have any questions. Would like to get your PR merged in.

@jmleoni
Copy link
Author

jmleoni commented Apr 13, 2015

Hi Juan.
I'll have a look ASAP

@rashidkpc rashidkpc removed the v4.1.0 label May 5, 2015
@panda01 panda01 assigned panda01 and unassigned jthomassie and panda01 May 20, 2015
@rashidkpc
Copy link
Contributor

Hi @jmleoni we're going to go ahead and close this for now. Feel free to look at the changes to the tile map, the new tests, and resubmit when you're ready. Thanks!

@rashidkpc rashidkpc closed this Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinate Maps: auto fit data bounds
4 participants