Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles map autozoom #2708

Closed
wants to merge 13 commits into from
Closed

Tiles map autozoom #2708

wants to merge 13 commits into from

Conversation

jmleoni
Copy link

@jmleoni jmleoni commented Jan 21, 2015

This should fix issue #2034

@rashidkpc
Copy link
Contributor

Can you add some details here? Describe the behavior and implementation? As far as I can tell this doesn't address #2034 as it doesn't increase the geohash_grid precision on zoom. It also looks like there's a number of debug statements left in the code.

Can you also rebase this on top of master?

@jmleoni
Copy link
Author

jmleoni commented Jan 26, 2015

This fix is very straight forward. It justs auto zooms to the feature layer area upon loading of a map.
Basically it is just like clicking on the FitControl button of the map. Indeed I was mistaken in the labelling of my commit, this is a fix for #2054 !

@rashidkpc
Copy link
Contributor

This pull contains a number of unrelated commits. Please fix your branch such that it does not contain the extra commits. Also please fix the description to reflect the ticket you are addressing.

@rashidkpc
Copy link
Contributor

I'd also like to see a toggle to turn this on and off on a per visualization basis. You can inject the toggle into the view options section

@rashidkpc
Copy link
Contributor

I haven't seen any feedback on this and we're trying to clean up the pull list for release. I'm going to go ahead and close the pull but feel free to reopen when you're ready.

@rashidkpc rashidkpc closed this Feb 10, 2015
@jmleoni
Copy link
Author

jmleoni commented Feb 10, 2015

Thanks Rashid. Sorry but fatherhood has taken its toll on me (I am now the proud father of a little Baptiste !) and I couldn't find any time to clean this up so far.
I just issued a new pull request with the missing config option #2970.
I should have everything that you need.

@spalger
Copy link
Contributor

spalger commented Feb 10, 2015

🎉 congrats @jmleoni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants