Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting hostname on the Zipkin collector config #14186

Closed
esmet opened this issue Nov 25, 2020 · 0 comments · Fixed by #14187
Closed

Support setting hostname on the Zipkin collector config #14186

esmet opened this issue Nov 25, 2020 · 0 comments · Fixed by #14187
Assignees
@esmet
Labels
enhancement Feature requests. Not bugs or questions.

Comments

@esmet
Copy link
Contributor

esmet commented Nov 25, 2020

Envoy should support setting the hostname used when sending spans to a Zipkin collector. Currently, the cluster name is used, but this isn't always the hostname that the upstream collector wants.

This should be a straightforward change to the Zipkin tracing config and the zipkin_tracer_impl.
@esmet esmet added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 25, 2020
@esmet esmet mentioned this issue Nov 25, 2020
Merged
@zuercher zuercher removed the triage Issue requires triage label Nov 25, 2020
mattklein123 pushed a commit that referenced this issue Dec 8, 2020
@esmet
tracing: Add hostname to Zipkin config. (#14186) (#14187)
940958e 
Signed-off-by: John Esmet <john.esmet@gmail.com>
mpuncel added a commit to mpuncel/envoy that referenced this issue Dec 8, 2020
@mpuncel
Merge branch 'master' into mpuncel/http2-hc-goaway
2b0d930 
* master: (41 commits)
  event: Remove a source of non-determinism by always running deferred deletion before post callbacks (envoyproxy#14293)
  Fix TSAN bug in integration test (envoyproxy#14327)
  tracing: Add hostname to Zipkin config.  (envoyproxy#14186) (envoyproxy#14187)
  [conn_pool] fix use after free in H/1 connection pool (envoyproxy#14220)
  lua: update deprecated lua_open to luaL_newstate (envoyproxy#14297)
  extension: use bool_flag to control extension link (envoyproxy#14240)
  stats: Factor out creation of cluster-stats StatNames from creation of the stats, to save CPU during xDS updates (envoyproxy#14028)
  test: add scaled timer integration test (envoyproxy#14290)
  [Win32 Signals] Add term and ctrl-c signal handlers (envoyproxy#13954)
  config: v2 transport API fatal-by-default. (envoyproxy#14223)
  matcher: fix UB bug caused by dereferencing a bad optional (envoyproxy#14271)
  test: putting fake upstream config in a struct (envoyproxy#14266)
  wasm: use Bazel rules from Proxy-Wasm Rust SDK. (envoyproxy#14292)
  docs: fix typo (envoyproxy#14237)
  dependencies: allowlist CVE-2018-21270 to prevent false positives. (envoyproxy#14294)
  typo in redis doc (envoyproxy#14248)
  access_loggers: removed redundant dep (envoyproxy#14274)
  fix http2 flaky test (envoyproxy#14261)
  test: disable flaky xds_integration_test. (envoyproxy#14287)
  http: add functionality to configure kill header in KillRequest proto (envoyproxy#14288)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esmet esmet

Labels
enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tracing: Add hostname to Zipkin config. (#14186) esmet/envoy
2 participants
@zuercher @esmet