wasm: use Bazel rules from Proxy-Wasm Rust SDK. #14292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
PiotrSikora
commented
Dec 5, 2020
| @@ -6,14 +6,14 @@ load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository") | |||
| load("@build_bazel_rules_apple//apple:repositories.bzl", "apple_rules_dependencies") | |||
There was a problem hiding this comment.
I couldn't figure out what's the difference between bazel/dependency_imports.bzl and bazel/repositories_extra.bzl, so let me know if I should move proxy_wasm_rust_sdk_dependencies() elsewhere.
|
Neat. can you check CI? |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
force-pushed
the
bazel_rules_from_proxy-wasm-rust-sdk
branch
from
f4323c9
to
6b01d4c
Compare
PiotrSikora
changed the title
lizan
approved these changes
Dec 5, 2020
moderation
reviewed
Dec 5, 2020
| project_name = "WebAssembly for Proxies (Rust SDK)", | ||
| project_desc = "WebAssembly for Proxies (Rust SDK)", | ||
| project_url = "https://github.com/proxy-wasm/proxy-wasm-rust-sdk", | ||
| version = "802cab2eabc1da106d8b8b7be2c7278b2bfadfbd", |
There was a problem hiding this comment.
This commit came just after the 0.1.3 release - https://github.com/proxy-wasm/proxy-wasm-rust-sdk/releases/tag/v0.1.3. Is the plan to leverage latest commits or use releases for this new dependency?
There was a problem hiding this comment.
Releases, but the change for better Bazel integration was added after v0.1.3 was tagged.
| version = "7b8219a1955ebd599c275bd292d8153e5616d6a4", | ||
| sha256 = "426a7712af597d90301dcc29e63d62de5c2e09fb347692e89abb775ec97c74fe", | ||
| version = "aa7c6938cf1cc2973bc065c7532f89874bf09818", | ||
| sha256 = "5cb2fbcc3debebc7b68f5f66c1b7ef741bdcca87c70594de688d4518538c36c8", | ||
| strip_prefix = "rules_rust-{version}", | ||
| urls = ["https://github.com/bazelbuild/rules_rust/archive/{version}.tar.gz"], | ||
| use_category = ["dataplane_ext"], | ||
| extensions = ["envoy.wasm.runtime.wasmtime"], |
There was a problem hiding this comment.
Is this list of extensions complete? The other dependencies from this Github org have a more comprehensive list - https://github.com/envoyproxy/envoy/blob/master/bazel/repository_locations.bzl#L820-L865
There was a problem hiding this comment.
Yes, rust is only used by wasmtime runtime.
There was a problem hiding this comment.
Note: this list is referring to rules_rust and not to proxy_wasm_rust_sdk.
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Dec 8, 2020
* master: (41 commits) event: Remove a source of non-determinism by always running deferred deletion before post callbacks (envoyproxy#14293) Fix TSAN bug in integration test (envoyproxy#14327) tracing: Add hostname to Zipkin config. (envoyproxy#14186) (envoyproxy#14187) [conn_pool] fix use after free in H/1 connection pool (envoyproxy#14220) lua: update deprecated lua_open to luaL_newstate (envoyproxy#14297) extension: use bool_flag to control extension link (envoyproxy#14240) stats: Factor out creation of cluster-stats StatNames from creation of the stats, to save CPU during xDS updates (envoyproxy#14028) test: add scaled timer integration test (envoyproxy#14290) [Win32 Signals] Add term and ctrl-c signal handlers (envoyproxy#13954) config: v2 transport API fatal-by-default. (envoyproxy#14223) matcher: fix UB bug caused by dereferencing a bad optional (envoyproxy#14271) test: putting fake upstream config in a struct (envoyproxy#14266) wasm: use Bazel rules from Proxy-Wasm Rust SDK. (envoyproxy#14292) docs: fix typo (envoyproxy#14237) dependencies: allowlist CVE-2018-21270 to prevent false positives. (envoyproxy#14294) typo in redis doc (envoyproxy#14248) access_loggers: removed redundant dep (envoyproxy#14274) fix http2 flaky test (envoyproxy#14261) test: disable flaky xds_integration_test. (envoyproxy#14287) http: add functionality to configure kill header in KillRequest proto (envoyproxy#14288) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Sikora piotrsikora@google.com