Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: doc typo #14237

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Fix: doc typo #14237

merged 1 commit into from
Dec 7, 2020

Conversation

hbrls
Copy link
Contributor

@hbrls hbrls commented Dec 2, 2020

doc typo

@repokitteh-read-only
Copy link

Hi @hbrls, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #14237 was opened by hbrls.

see: more, trace.

phlax
phlax previously approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @hbrls

@phlax
Copy link
Member

phlax commented Dec 2, 2020

@hlbris you will need to fix DCO - see here for more information

https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#dco-sign-your-work

@phlax phlax mentioned this pull request Dec 3, 2020
Closed
@hbrls
Update front_proxy.rst
3113352 
typo
Signed-off-by: Albert <shuaizhexu@gmail.com>
@hbrls
Copy link
Contributor Author

hbrls commented Dec 3, 2020

I have followed the instructions and seen a Signed-off-by by the end of commit message. Please check if it's correct.

@phlax
Copy link
Member

phlax commented Dec 3, 2020

all seems good now - thanks @hbrls

@mattklein123 mattklein123 merged commit e7323c3 into envoyproxy:master Dec 7, 2020
@hbrls hbrls deleted the patch-2 branch December 7, 2020 05:50
mpuncel added a commit to mpuncel/envoy that referenced this pull request Dec 8, 2020
@mpuncel
Merge branch 'master' into mpuncel/http2-hc-goaway
2b0d930 
* master: (41 commits)
  event: Remove a source of non-determinism by always running deferred deletion before post callbacks (envoyproxy#14293)
  Fix TSAN bug in integration test (envoyproxy#14327)
  tracing: Add hostname to Zipkin config.  (envoyproxy#14186) (envoyproxy#14187)
  [conn_pool] fix use after free in H/1 connection pool (envoyproxy#14220)
  lua: update deprecated lua_open to luaL_newstate (envoyproxy#14297)
  extension: use bool_flag to control extension link (envoyproxy#14240)
  stats: Factor out creation of cluster-stats StatNames from creation of the stats, to save CPU during xDS updates (envoyproxy#14028)
  test: add scaled timer integration test (envoyproxy#14290)
  [Win32 Signals] Add term and ctrl-c signal handlers (envoyproxy#13954)
  config: v2 transport API fatal-by-default. (envoyproxy#14223)
  matcher: fix UB bug caused by dereferencing a bad optional (envoyproxy#14271)
  test: putting fake upstream config in a struct (envoyproxy#14266)
  wasm: use Bazel rules from Proxy-Wasm Rust SDK. (envoyproxy#14292)
  docs: fix typo (envoyproxy#14237)
  dependencies: allowlist CVE-2018-21270 to prevent false positives. (envoyproxy#14294)
  typo in redis doc (envoyproxy#14248)
  access_loggers: removed redundant dep (envoyproxy#14274)
  fix http2 flaky test (envoyproxy#14261)
  test: disable flaky xds_integration_test. (envoyproxy#14287)
  http: add functionality to configure kill header in KillRequest proto (envoyproxy#14288)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

@phlax phlax phlax left review comments

Assignees

@phlax phlax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbrls @phlax @mattklein123