Fixes for publish workflows #1319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This fixes a few issues encountered during publishing Yoga `2.0.0-beta.1`. 1. The tag trigger was missing quotes needed to be valid syntax 2. `pod trunk publish` must be run with `--synchronous` if we are publishing a package that relies on another just published package. There does not seem to be a way to just publish evertything at once. 3. `yarn publish` was not reading the NPM auth token from the environment, so we write it to a `.npmrc` before publishing. 4. The root `.gitignore` was not updated when moving to yarn workspaces to ignore `node_modules`, so the OSS Yoga repo (not internal) will, try to add its contents after `yarn install`. Differential Revision: D47135994 fbshipit-source-id: 2bf393c1e16c47ba3aeb1116f050cf12fb59932b
|
This pull request was exported from Phabricator. Differential Revision: D47135994 |
|
This pull request has been merged in 1b40f05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes a few issues encountered during publishing Yoga
2.0.0-beta.1.pod trunk publishmust be run with--synchronousif we are publishing a package that relies on another just published package. There does not seem to be a way to just publish evertything at once.yarn publishwas not reading the NPM auth token from the environment, so we write it to a.npmrcbefore publishing..gitignorewas not updated when moving to yarn workspaces to ignorenode_modules, so the OSS Yoga repo (not internal) will, try to add its contents afteryarn install.Differential Revision: D47135994