Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for publish workflows #1319

Closed
wants to merge 1 commit into from
Closed

Fixes for publish workflows #1319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-android-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish Android Release
on:
push:
tags:
- *
- '*'
workflow_dispatch:

jobs:
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/publish-cocoapods-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish CocoaPods Release
on:
push:
tags:
- *
- '*'
workflow_dispatch:

jobs:
Expand All @@ -23,6 +23,7 @@ jobs:
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}

- name: Publish YogaKit
run: pod trunk push YogaKit.podspec
# Must run with --synchronous since YogaKit may depend on the just published version of Yoga
run: pod trunk push YogaKit.podspec --synchronous
env:
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}
7 changes: 4 additions & 3 deletions .github/workflows/publish-npm-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish NPM Release
on:
push:
tags:
- *
- '*'
workflow_dispatch:

jobs:
Expand All @@ -17,8 +17,9 @@ jobs:
- name: Setup
uses: ./.github/actions/setup-js

- name: Store auth token in config file
run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc

- name: yarn publish
run: yarn publish
working-directory: javascript
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
/.buckd
/gentest/test.html
.buck-java11
node_modules

# Jekyll
/.sass-cache/
Expand Down
1 change: 0 additions & 1 deletion javascript/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/binaries
/build
/dist
/node_modules
3 changes: 0 additions & 3 deletions website-next/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# Dependencies
/node_modules

# Production
/build

Expand Down
2 changes: 0 additions & 2 deletions website/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# Project dependencies
# https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git
node_modules
.cache/
# Build directory
public/
Expand Down