Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for publish workflows #1319

Closed
wants to merge 1 commit into from

Commits on Jun 29, 2023

  1. Fixes for publish workflows

    Summary:
    This fixes a few issues encountered during publishing Yoga `2.0.0-beta.1`.
    
    1. The tag trigger was missing quotes needed to be valid syntax
    2. `pod trunk publish` must be run with `--synchronous` if we are publishing a package that relies on another just published package. There does not seem to be a way to just publish evertything at once.
    3. `yarn publish` was not reading the NPM auth token from the environment, so we write it to a `.npmrc` before publishing.
    4. The root `.gitignore` was not updated when moving to yarn workspaces to ignore `node_modules`, so the OSS Yoga repo (not internal) will, try to add its contents after `yarn install`.
    
    Differential Revision: D47135994
    
    fbshipit-source-id: 2bf393c1e16c47ba3aeb1116f050cf12fb59932b
    NickGerleman authored and facebook-github-bot committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b204053 View commit details
    Browse the repository at this point in the history