Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch routing from teams to product areas #126

Closed
37 tasks done
Tracked by #90
chadwhitacre opened this issue Apr 19, 2023 · 11 comments
Closed
37 tasks done
Tracked by #90

Switch routing from teams to product areas #126

chadwhitacre opened this issue Apr 19, 2023 · 11 comments
Assignees

Comments

@chadwhitacre
Copy link
Member

chadwhitacre commented Apr 19, 2023

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Apr 20, 2023

@hubertdeng123 at getsentry/eng-pipes#436 (comment):

Looks like this PR will break the hourly triage notifications that exist today, since Team: * labels still exist. With that said, is there a plan to clean the existing database so that the Team: * labels no longer exist as entries in label_to_channel? Will channels that Product Owners subscribe to be created before the team labels are switched to product area labels on GH issues?

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Apr 21, 2023

is there a plan to clean the existing database so that the Team: * labels no longer exist as entries in label_to_channel?

We could drop the table and recreate it in a migration. That wouldn't require ops intervention. It would mean starting from scratch with notifications, which probably isn't the end of the world since the change from teams to product owners is pretty significant already.

Will channels that Product Owners subscribe to be created before the team labels are switched to product area labels on GH issues?

I think the answer is no. I think we should land getsentry/sentry#47156 asap, start manually moving tickets to the labels to get a sense for what might be missing, and then bring in the automation when we're ready.

This was referenced Apr 24, 2023
@chadwhitacre chadwhitacre self-assigned this May 1, 2023
@chadwhitacre
Copy link
Member Author

chadwhitacre commented May 1, 2023

Deployed getsentry/eng-pipes#436! I set up a notification subscription in #feed-issues and tested routing with getsentry/sentry#48246. It failed. Gonna debug in getsentry/sentry#46554.

Also a weird result🔒 from subscription:

Set untriaged issue notifications for '[object Object]' on the current channel (feed-issues).

@chadwhitacre
Copy link
Member Author

Routing fixed in getsentry/eng-pipes#439.

@chadwhitacre
Copy link
Member Author

Move issues from "Team: Foo" to "Product Area: Foo"

Chatted with @souredoutlook & Co. Not sure of the value here for old tickets. Need to think this out more. 🤔

@chadwhitacre
Copy link
Member Author

I made https://github.com/getsentry/security-as-code/pull/71 to fill out remaining empty areas after talking with Zac.

I need to get that merged and then set up notifications for all teams. I think I need to make one more PR to adjust membership for some perf-related areas.

@chadwhitacre
Copy link
Member Author

chadwhitacre commented May 3, 2023

Notifications

  • "Product Area: Alerts" ⇒ #feed-gh-issues (sfo)
  • "Product Area: Crons" ⇒ #discuss-crons (sfo)
  • "Product Area: Dashboards" ⇒ #feed-gh-dnd (yyz)
  • "Product Area: Discover" ⇒ #feed-gh-dnd (yyz)
  • "Product Area: Footer" ⇒ #feed-gh-issues (sfo)
  • "Product Area: Help" ⇒ #discuss-support-open-source (sfo, yyz)
  • "Product Area: Issues" ⇒ #feed-gh-issues (sfo)
  • "Product Area: Other" ⇒ #team-ospo (sea)
  • "Product Area: Performance" ⇒ #feed-gh-performance (yyz)
  • "Product Area: Profiling" ⇒ #team-profiling (sfo, yyz)
  • "Product Area: Projects" ⇒ #feed-gh-projects (yyz)
  • "Product Area: Releases" ⇒ #feed-gh-issues (sfo)
  • "Product Area: Replays" ⇒ #feed-replay-alerts (yyz)
  • "Product Area: Service Status" ⇒ #feed-gh-issues (sfo)
  • "Product Area: Settings" ⇒ #feed-gh-issues (sfo)
  • "Product Area: Settings - Auth" ⇒ #discuss-enterprise (sfo)
  • "Product Area: Settings - Developer Settings" ⇒ #discuss-integrations (sfo)
  • "Product Area: Settings - Integrations" ⇒ #discuss-integrations (sfo)
  • "Product Area: Settings - Members" ⇒ #discuss-enterprise (sfo)
  • "Product Area: Settings - Projects" ⇒ #discuss-enterprise (sfo)
  • "Product Area: Settings - Relay" ⇒ #discuss-ingest (vie)
  • "Product Area: Settings - Repositories" ⇒ #discuss-integrations (sfo)
  • "Product Area: Settings - Security & Privacy" ⇒ #feed-gh-issues (sfo)
  • "Product Area: Settings - Spike Protection" ⇒ #discuss-enterprise (sfo)
  • "Product Area: Settings - Teams" ⇒ #discuss-enterprise (sfo)
  • "Product Area: Sign In" ⇒ #discuss-enterprise (sfo)
  • "Product Area: Stats" ⇒ #feed-gh-issues (sfo)
  • "Product Area: User Feedback" ⇒ #feed-gh-issues (sfo)
  • "Product Area: What's New" ⇒ #feed-gh-whatsnew (sfo)

@chadwhitacre
Copy link
Member Author

Waiting for an automation to run to populate members of GitHub teams, then I can close this out.

@chadwhitacre
Copy link
Member Author

@chadwhitacre
Copy link
Member Author

Populated!

@chadwhitacre
Copy link
Member Author

😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant