Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from dotnet/SqlClient #5

Merged
merged 10 commits into from
Oct 3, 2019
Merged

Conversation

karinazhou
Copy link
Owner

No description provided.

cheenamalhotra and others added 10 commits September 26, 2019 13:42
ensure that cleanup of certificates happens if one is created
add single test run command to buildguide
* Revert Resource API changes in SqlAuthenticationParameter

* Generalize
…ence (#210)

Contributors:
@JRahnama @v-kaywon @cheenamalhotra 

Changes with this PR:
- Adds common XML doc snippets to be extracted for XML documentation
- Adds Samples to repository included in documentation
- Updated both NetFx and NetCore drivers with documentation includes.
- GitIgnore update to exclude `nuget.exe`
- build.proj now defaults to `BuildAllConfigurations` target. Addresses #197
- Added include tags in 'ref' classes for Visual Studio Intellisense support.

Additional Changes in this PR:
- `Microsoft.Data.SqlTypes.SqlFileStream` added in NetFx.
- Existing tests run against the newly added SqlFileStream class.

As of now, this PR brings documentation over from System.Data.SqlClient.
Work to be continued to enhance missing docs in future PRs.
@karinazhou karinazhou merged commit 06f29a3 into karinazhou:master Oct 3, 2019
karinazhou pushed a commit that referenced this pull request Nov 15, 2019
* Get and set expected value for DdType.Date and DbType.Time

Breaks support for SQL Server 2008 (I believe)

fixes #5

Extend DateTimeTest.ReaderParameterTest to cover DbType parameters
karinazhou added a commit that referenced this pull request Mar 31, 2021
* Add event counters

* Add support netstandard 2.1 & fix the conflict in event source

* Support new event source types & add the test unit

* Remove supporting obsolete types

* fix unit test

* Add snippet sample code

* Address comments

* Fix minor typo (#3)

* Reformatting counter methods

* Fix minor typo

* Removed IsEnabled condition and reformatted counter methods

* Unit tests for Microsoft.Data.SqlClient.SqlClientEventSource (#2)

* Implemented tests for Microsoft.Data.SqlClient.SqlClientEventSource

* Updated the EventCounter test to reflect the recent changes in the code

* Working on EventCounter tests access event counters through reflection

* Updated the EventCounterTest to use reflection

* Fixing dangling SqlConnection's left in tests

* EventCountersTest now checks hard/soft connects/disconnects counters

* Reverted the DataTestUtility changes

* Reverted using statements to the old-style in tests

* Reverted the ConnectionPoolTest.ReclaimEmancipatedOnOpenTest()

* Reverted using statements to the old-style in tests

* Reverted using statements to the old-style in tests

* Rewrite the EventCounterTest assertions not to conflict with other tests

* Code review cleanup

* Add more tests (#5)

Added EventCounter_ReclaimedConnectionsCounter_Functional & EventCounter_ConnectionPoolGroupsCounter_Functional tests.

* Address comments

Co-authored-by: Davoud Eshtehari <David.esh@gmail.com>
Co-authored-by: Davoud Eshtehari <v-daesht@microsoft.com>
Co-authored-by: Karina Zhou <v-jizho2@microsoft.com>
Co-authored-by: Nikita Kobzev <win.accuracy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants