-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger repaint after BitmapWidget
is updated.
#1797
Merged
pengdev
merged 7 commits into
main
from
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
Nov 4, 2022
Merged
Trigger repaint after BitmapWidget
is updated.
#1797
pengdev
merged 7 commits into
main
from
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengdev
force-pushed
the
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
branch
from
November 3, 2022 12:23
c730788
to
da59fa8
Compare
paulrenn67
approved these changes
Nov 3, 2022
pengdev
force-pushed
the
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
branch
from
November 3, 2022 12:56
da59fa8
to
72c73bc
Compare
jush
reviewed
Nov 3, 2022
kiryldz
reviewed
Nov 3, 2022
jush
approved these changes
Nov 3, 2022
pengdev
force-pushed
the
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
branch
from
November 3, 2022 14:06
d728a71
to
5b29680
Compare
pengdev
force-pushed
the
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
branch
from
November 3, 2022 14:11
5b29680
to
c558cef
Compare
ank27
reviewed
Nov 3, 2022
jush
reviewed
Nov 3, 2022
pengdev
force-pushed
the
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
branch
from
November 3, 2022 14:56
f37490b
to
7efd80b
Compare
kiryldz
reviewed
Nov 3, 2022
kiryldz
reviewed
Nov 3, 2022
kiryldz
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💎
pengdev
changed the title
Add triggerRepaint protected method to Widget.
Update the Nov 4, 2022
BitmapWidget
to trigger repaint after widget is updated.
pengdev
force-pushed
the
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
branch
from
November 4, 2022 09:45
18d744e
to
b15b5be
Compare
pengdev
changed the title
Update the
Trigger repaint after Nov 4, 2022
BitmapWidget
to trigger repaint after widget is updated. BitmapWidget
is updated.
jush
approved these changes
Nov 4, 2022
ank27
approved these changes
Nov 4, 2022
pengdev
deleted the
MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation
branch
November 4, 2022 10:55
pengdev
added a commit
that referenced
this pull request
Nov 4, 2022
9 tasks
pengdev
added a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds
Widget.triggerRepaint
internal method, to be able to trigger immediate repaint of the widget.Also updated the BitmapWidget to trigger repaint after bitmap, position or rotation is changed.
User impact (optional)
Pull request checklist:
@JvmOverloads
,@file:JvmName
, etc).make update-api
to update generated api files, if there's public API changes, otherwise theverify-api-*
CI steps might fail.check changelog
CI step will fail.v10.[version]
release branch fix / enhancement, merge it tomain
firstly and then port tov10.[version]
release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.