Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger repaint after BitmapWidget is updated. #1797

Conversation

pengdev
Copy link
Member

@pengdev pengdev commented Nov 3, 2022

Summary of changes

This PR adds Widget.triggerRepaint internal method, to be able to trigger immediate repaint of the widget.
Also updated the BitmapWidget to trigger repaint after bitmap, position or rotation is changed.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@pengdev pengdev self-assigned this Nov 3, 2022
@pengdev pengdev force-pushed the MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation branch from c730788 to da59fa8 Compare November 3, 2022 12:23
@pengdev pengdev force-pushed the MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation branch from da59fa8 to 72c73bc Compare November 3, 2022 12:56
@pengdev pengdev force-pushed the MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation branch from d728a71 to 5b29680 Compare November 3, 2022 14:06
@pengdev pengdev force-pushed the MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation branch from 5b29680 to c558cef Compare November 3, 2022 14:11
@pengdev pengdev marked this pull request as ready for review November 3, 2022 14:54
@pengdev pengdev requested review from a team as code owners November 3, 2022 14:54
@pengdev pengdev force-pushed the MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation branch from f37490b to 7efd80b Compare November 3, 2022 14:56
CHANGELOG.md Outdated Show resolved Hide resolved
@pengdev pengdev requested a review from kiryldz November 4, 2022 09:42
Copy link
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@pengdev pengdev changed the title Add triggerRepaint protected method to Widget. Update the BitmapWidget to trigger repaint after widget is updated. Nov 4, 2022
@pengdev pengdev force-pushed the MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation branch from 18d744e to b15b5be Compare November 4, 2022 09:45
@pengdev pengdev changed the title Update the BitmapWidget to trigger repaint after widget is updated. Trigger repaint after BitmapWidget is updated. Nov 4, 2022
@pengdev pengdev merged commit c932cc0 into main Nov 4, 2022
@pengdev pengdev deleted the MAPSAND-532-map-view-should-be-refreshed-on-widget-set-translation-or-widget-set-rotation branch November 4, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants