Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Avoid NaN values in data textures in webgl_gpgpu_birds_gltf. #19885

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Examples: Avoid NaN values in data textures in webgl_gpgpu_birds_gltf. #19885

merged 1 commit into from
Jul 20, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 20, 2020

Fixed #19876.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 20, 2020 •
edited
Loading

@santi-grau I've patched the code to avoid NaN values. However, I suggest to refactor the way how textureAnimation is generated in order to avoid these checks. If you have some sparse time, please try to improve this code.

@mrdoob mrdoob added this to the r119 milestone Jul 20, 2020
@mrdoob mrdoob merged commit e2b1030 into mrdoob:dev Jul 20, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jul 20, 2020

Thanks!

@santi-grau
Copy link
Contributor

got it, will take a look if I get some time this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r119
Development

Successfully merging this pull request may close these issues.

NaN in float texture
3 participants
@Mugen87 @mrdoob @santi-grau