Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport.js: Added user camera preview function. #20953

Closed
wants to merge 1 commit into from
Closed

Viewport.js: Added user camera preview function. #20953

wants to merge 1 commit into from

Conversation

1993heqiang
Copy link
Contributor

@1993heqiang 1993heqiang commented Dec 28, 2020

Description
Some functions of the user's camera preview are realized, including position movement, rotation, and zooming.

PS:
When I added a custom camera in the editor, and then switched to the custom camera, I found that the objects in the scene could not be operated, so I modified it. This modification is based on my personal thoughts. If you have any comments, please let me know.

image

…, including position movement, rotation, and zooming.
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 28, 2020

I'm afraid this changes goes in the wrong direction. The idea is to implement a switch for changing between orthographic and perspective cameras like outlined here: #16008.

It's not intended that the cameras from the selection box replace the default editor camera. It's also not appropriate to introduce OrbitControls to the editor.

@1993heqiang
Copy link
Contributor Author

1993heqiang commented Dec 28, 2020

I'm afraid this changes goes in the wrong direction. The idea is to implement a switch for changing between orthographic and perspective cameras like outlined here: #16008.

It's not intended that the cameras from the selection box replace the default editor camera. It's also not appropriate to introduce OrbitControls to the editor.

I did not see this discussion #16008 before submitting the PR. I also agree with your views. :)

@1993heqiang 1993heqiang deleted the local_dev2 branch December 29, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants