Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Video fix wrong colorSpace in WebGL Backend #29254

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #26516 #29213

Description

Use sRGB decode until browsers properly support SRGB8_ALPHA8 with video textures (#26516)

This contribution is funded by Utsubo

@RenaudRohlinger
Copy link
Collaborator Author

RenaudRohlinger commented Aug 29, 2024

This PR along with #29255 fixes some issues on the official examples, should we include these in r168 or r169? /cc @mrdoob @Mugen87 @sunag

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
WebGLRenderer 685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B
WebGPURenderer 818.5 kB (221.2 kB) 818.6 kB (221.2 kB) +79 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
WebGLRenderer 462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
WebGPURenderer 564.7 kB (153.3 kB) 564.8 kB (153.4 kB) +78 B

@mrdoob
Copy link
Owner

mrdoob commented Aug 29, 2024

This PR along with #29255 fixes some issues on the official examples, should we include these in r168 or r169? /cc @mrdoob @Mugen87 @sunag

They can go in r168. I'll do the release tomorrow (in ~12 hours).

@RenaudRohlinger RenaudRohlinger added this to the r168 milestone Aug 29, 2024
@sunag sunag merged commit 2b74466 into mrdoob:dev Aug 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants