Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Ensure correct pixel storage parameters in WebGL Backend #29255

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #29213

Description

Ensure correct pixel storage parameters are set before updating texture data. Fixes videos being flipped on resize (#29213) and aligns behavior with the WebGLRenderer.

This contribution is funded by Utsubo

Copy link

github-actions bot commented Aug 29, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
WebGLRenderer 685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B
WebGPURenderer 818.5 kB (221.2 kB) 818.5 kB (221.2 kB) +31 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
WebGLRenderer 462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
WebGPURenderer 564.7 kB (153.3 kB) 564.8 kB (153.3 kB) +31 B

@RenaudRohlinger
Copy link
Collaborator Author

First live preview of #29251 /cc @mrdoob 👀

@RenaudRohlinger RenaudRohlinger added this to the r168 milestone Aug 29, 2024
@sunag sunag merged commit 761a424 into mrdoob:dev Aug 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants