fix(linter): improve no-zero-fractions rule for member expressions and scientific notation #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a check for parent nodes that are MemberExpressions - If a parent node is a MemberExpression, the fixed number is now wrapped in parentheses to maintain correct syntax
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4793 will not alter performanceComparing Summary
|
This commit enhances the no-zero-fractions rule in the unicorn linter: - Add support for scientific notation (e.g., 1e10, 1.e10) - Improve handling of member expressions - Introduce is_decimal_integer utility function - Update test cases and snapshots to reflect new behavior - Fix various edge cases in number formatting These changes make the rule more robust and consistent with the original ESLint implementation, especially for scientific notation and member expressions.
…g and clarity
- Simplified the condition that checks for decimal integers within member expressions by removing unnecessary parentheses around the formatted string.
- Updated string formatting in `format_raw` function to use the shorthand `{variable}` syntax instead of `{}` with positional arguments.
cblh
changed the title
cblh
changed the title
- Handle special cases where a space is needed after certain keywords (return, throw, typeof) to prevent the number from being interpreted as a property access - Add tests for these special cases - Update existing tests to cover more scenarios
cblh
changed the title
- Include 'void' in the list of keywords that require a space before the number to prevent misinterpretation as property access - Add test cases for 'void' keyword scenarios
DonIsaac
reviewed
Aug 12, 2024
…o-zero-fractions` rule - Removed the `is_decimal_integer` function and related `numeric.rs` utility, as it was no longer necessary. - Simplified the `no-zero-fractions` rule by directly checking for non-dangling dots instead of using the removed utility. - Updated the logic for fixing number formatting to remove redundant checks.
…s and decimal integers - Refactored logic in the `NoZeroFractions` rule to ensure proper handling of cases where the numeric value is a decimal integer and part of a member expression. - Added a clone of the format string to avoid mutating the original `fmt`. - Introduced checks for `is_decimal_integer` and `is_member_expression` to better control the formatting of the fixed value. - Updated test cases to cover additional scenarios, including fixing fractional values like `1.010.toFixed(2)` to `1.01.toFixed(2)`.
DonIsaac
approved these changes
Aug 14, 2024
|
Is there still a service disruption for Github Actions? |
@DonIsaac github action service has been restored |
- Add TODO for more complex token checks and semicolon handling - Prepare for special keyword cases requiring space after fixed value
- Add TODO for more complex token checks and
Merged
Boshen
added a commit
that referenced
this pull request
Aug 23, 2024
## [0.8.0] - 2024-08-23 - 5f4c9ab semantic: [**BREAKING**] Rename `SymbolTable::get_flag` to `get_flags` (#5030) (overlookmotel) - ce4d469 codegen: [**BREAKING**] Remove const generic `MINIFY` (#5001) (Boshen) - b2ff2df parser: [**BREAKING**] Remove builder pattern from `Parser` struct (#5000) (Boshen) - f88970b ast: [**BREAKING**] Change order of fields in CallExpression (#4859) (Burlin) ### Features - 2292606 linter: Typescript-eslint/no-wrapper-object-types (#5022) (camc314) - a0effab linter: Support more flexible config.globals values (#4990) (Don Isaac) - cdbfcfb linter: Start import fixer for eslint/no-unused-vars (#4849) (DonIsaac) - 915cb4d linter: Add dangerous fixer for oxc only used in recursion (#4805) (camc314) - 3f28c77 linter/eslint: Improve no-dupe-keys (#4943) (DonIsaac) - e1582a5 linter/eslint: Improve no-duplicate-case rule (#4942) (DonIsaac) - f1e4611 linter/eslint-plugin-vitest: Implement no-conditional-in-test (#4971) (dalaoshu) - 14bf5d5 linter/eslint-plugin-vitest: Implement no-restricted-vi-methods (#4956) (dalaoshu) - ed9a1c4 linter/eslint-plugin-vitest: Implement require-local-test-context-for-concurrent-snapshots (#4951) (dalaoshu) - 7859f58 linter/eslint-plugin-vitest: Implement no-conditional-tests (#4955) (dalaoshu) - 841174f linter/no-unused-vars: Delete non-root arrows, skip `await` (#5083) (Don Isaac) ### Bug Fixes - 86d0c0c linter: Change consistent-function-scoping to suspicious (#5010) (DonIsaac) - 7b99386 linter: Missing closing ticks in some example blocks (#4994) (DonIsaac) - 9c64b12 linter: Improve no-zero-fractions rule for member expressions and scientific notation (#4793) (Burlin) - c43945c linter/consistent-function-scoping: Allow functions passed as arguments (#5011) (Don Isaac) - 9354779 linter/no-unused-vars: Give `argsIgnorePattern` the same default behavior as `varsIgnorePattern` (#5018) (DonIsaac) - 5a55dcf linter/no-unused-vars: `type` specifier not deleted for type imports (#5029) (DonIsaac) - 4081293 linter/no-unused-vars: Panic in fixer when removing destructures (#4923) (Don Isaac) - ddf83ff linter/react: Fixed false positive with missing key inside React.Children.toArray() (#4945) (Earl Chase) - 508644a linter/tree-shaking: Correct the calculation of `>>`, `<<` and `>>>` (#4932) (mysteryven) - e99836d linter/unicorn: Allow set spreading in no-useless-spread (#4944) (Don Isaac) - 5f8a7c2 oxlint: Rules in the configuration file are not being correctly … (#4949) (dalaoshu) ### Documentation - e331ca0 linter: Improve documentation for several rules (#4997) (DonIsaac) - cd9f1cd linter/consistent-function-scoping: Improve rule documentation (#5015) (DonIsaac) ### Refactor - eca6fdb linter: Move plugin options into separate struct (#5100) (DonIsaac) - 06f2d81 linter: Avoid unnecessary temp `Vec`s (#4963) (overlookmotel) - 4cb8c37 linter: Move default_true to utils (#4947) (Don Isaac) - ca70cc7 linter, mangler, parser, semantic, transformer, traverse, wasm: Rename various `flag` vars to `flags` (#5028) (overlookmotel) - 59d15c7 semantic: `root_unresolved_references` contain only `ReferenceId` (#4959) (overlookmotel) ### Testing - c21d735 linter/no-unused-vars: Add ignored destructuring test cases (#4922) (Don Isaac) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4788