Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(linter/consistent-function-scoping): improve rule documentation #5015

Merged
merged 1 commit into from
Aug 21, 2024
Merged

docs(linter/consistent-function-scoping): improve rule documentation #5015

merged 1 commit into from
Aug 21, 2024

Conversation

DonIsaac
Copy link
Collaborator

No description provided.

@DonIsaac DonIsaac added the A-linter Area - Linter label Aug 20, 2024 — with Graphite App
@DonIsaac DonIsaac mentioned this pull request Aug 20, 2024
Merged
@DonIsaac Graphite App
Copy link
Collaborator Author

DonIsaac commented Aug 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@DonIsaac DonIsaac mentioned this pull request Aug 20, 2024
Merged
@DonIsaac DonIsaac added the C-docs Category - Documentation. Related to user-facing or internal documentation label Aug 20, 2024 — with Graphite App
@DonIsaac DonIsaac marked this pull request as ready for review August 20, 2024 16:08
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac mentioned this pull request Aug 20, 2024
Closed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 20, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5015 will not alter performance

Comparing don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation (cd9f1cd) with main (83dfb14)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/08-20-fix_linter/consistent-function-scoping_allow_functions_passed_as_arguments branch from e827d80 to bf731af Compare August 20, 2024 16:26
@DonIsaac DonIsaac requested a review from camc314 August 20, 2024 16:26
@DonIsaac DonIsaac force-pushed the don/08-20-fix_linter/consistent-function-scoping_allow_functions_passed_as_arguments branch from bf731af to fd18d4c Compare August 20, 2024 16:27
@DonIsaac DonIsaac force-pushed the don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation branch 2 times, most recently from 7f8609a to dd8e2a1 Compare August 20, 2024 16:27
Base automatically changed from don/08-20-fix_linter/consistent-function-scoping_allow_functions_passed_as_arguments to main August 20, 2024 21:00
@DonIsaac DonIsaac force-pushed the don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation branch from dd8e2a1 to 9e4c130 Compare August 20, 2024 21:01
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 21, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 21, 2024 •
edited
Loading

Merge activity

  • Aug 20, 8:16 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Aug 20, 8:17 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Aug 20, 9:07 PM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation branch from 9e4c130 to cd9f1cd Compare August 21, 2024 00:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 21, 2024
@graphite-app graphite-app bot merged commit cd9f1cd into main Aug 21, 2024
24 checks passed
@graphite-app graphite-app bot deleted the don/08-20-docs_linter/consistent-function-scoping_improve_rule_documentation branch August 21, 2024 01:07
@oxc-bot oxc-bot mentioned this pull request Aug 23, 2024
Merged
Boshen added a commit that referenced this pull request Aug 23, 2024
@oxc-bot @Boshen
Release oxlint v0.8.0 (#5104)
8ef85a4 
## [0.8.0] - 2024-08-23

- 5f4c9ab semantic: [**BREAKING**] Rename `SymbolTable::get_flag` to
`get_flags` (#5030) (overlookmotel)

- ce4d469 codegen: [**BREAKING**] Remove const generic `MINIFY` (#5001)
(Boshen)

- b2ff2df parser: [**BREAKING**] Remove builder pattern from `Parser`
struct (#5000) (Boshen)

- f88970b ast: [**BREAKING**] Change order of fields in CallExpression
(#4859) (Burlin)

### Features

- 2292606 linter: Typescript-eslint/no-wrapper-object-types (#5022)
(camc314)
- a0effab linter: Support more flexible config.globals values (#4990)
(Don Isaac)
- cdbfcfb linter: Start import fixer for eslint/no-unused-vars (#4849)
(DonIsaac)
- 915cb4d linter: Add dangerous fixer for oxc only used in recursion
(#4805) (camc314)
- 3f28c77 linter/eslint: Improve no-dupe-keys (#4943) (DonIsaac)
- e1582a5 linter/eslint: Improve no-duplicate-case rule (#4942)
(DonIsaac)
- f1e4611 linter/eslint-plugin-vitest: Implement no-conditional-in-test
(#4971) (dalaoshu)
- 14bf5d5 linter/eslint-plugin-vitest: Implement
no-restricted-vi-methods (#4956) (dalaoshu)
- ed9a1c4 linter/eslint-plugin-vitest: Implement
require-local-test-context-for-concurrent-snapshots (#4951) (dalaoshu)
- 7859f58 linter/eslint-plugin-vitest: Implement no-conditional-tests
(#4955) (dalaoshu)
- 841174f linter/no-unused-vars: Delete non-root arrows, skip `await`
(#5083) (Don Isaac)

### Bug Fixes

- 86d0c0c linter: Change consistent-function-scoping to suspicious
(#5010) (DonIsaac)
- 7b99386 linter: Missing closing ticks in some example blocks (#4994)
(DonIsaac)
- 9c64b12 linter: Improve no-zero-fractions rule for member expressions
and scientific notation (#4793) (Burlin)
- c43945c linter/consistent-function-scoping: Allow functions passed as
arguments (#5011) (Don Isaac)
- 9354779 linter/no-unused-vars: Give `argsIgnorePattern` the same
default behavior as `varsIgnorePattern` (#5018) (DonIsaac)
- 5a55dcf linter/no-unused-vars: `type` specifier not deleted for type
imports (#5029) (DonIsaac)
- 4081293 linter/no-unused-vars: Panic in fixer when removing
destructures (#4923) (Don Isaac)
- ddf83ff linter/react: Fixed false positive with missing key inside
React.Children.toArray() (#4945) (Earl Chase)
- 508644a linter/tree-shaking: Correct the calculation of `>>`, `<<` and
`>>>` (#4932) (mysteryven)
- e99836d linter/unicorn: Allow set spreading in no-useless-spread
(#4944) (Don Isaac)
- 5f8a7c2 oxlint: Rules in the configuration file are not being
correctly … (#4949) (dalaoshu)

### Documentation

- e331ca0 linter: Improve documentation for several rules (#4997)
(DonIsaac)
- cd9f1cd linter/consistent-function-scoping: Improve rule documentation
(#5015) (DonIsaac)

### Refactor

- eca6fdb linter: Move plugin options into separate struct (#5100)
(DonIsaac)
- 06f2d81 linter: Avoid unnecessary temp `Vec`s (#4963) (overlookmotel)
- 4cb8c37 linter: Move default_true to utils (#4947) (Don Isaac)
- ca70cc7 linter, mangler, parser, semantic, transformer, traverse,
wasm: Rename various `flag` vars to `flags` (#5028) (overlookmotel)
- 59d15c7 semantic: `root_unresolved_references` contain only
`ReferenceId` (#4959) (overlookmotel)

### Testing

- c21d735 linter/no-unused-vars: Add ignored destructuring test cases
(#4922) (Don Isaac)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 Awaiting requested review from camc314

Assignees
No one assigned
Labels
A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonIsaac @Boshen