Update name in acknowledgements and add mailmap #103696
Conversation
I changed my name last year, and would like to update my name in the acknowledgements and git history accordingly. git-mailmap reference: https://git-scm.com/docs/gitmailmap
|
All commit authors signed the Contributor License Agreement. |
arhadthedev
added
skip issue
skip news
needs backport to 3.11
|
From what I can see, GitHub doesn't support the mailmap file (there are discussions about it as early as 2013 that I've found), a recent official confirmation being found here. I don't think it is worth it to add the mailmap file as of this, the recommendation is to add the old email to your profile. On changing your name in ACKS–I'm not sure what level of proof is reasonable to demonstrate you're the same person! Are you able to log in with an old account that uses that email and leave a confirmatory comment, or an email reply to this issue with your old email address? Perhaps I'm overthinking the issue though. A |
My Github account already includes my old email addresses, and the commits are associated with my new name, so I'm more concerned with fixing the output of
Relevant commits are 3a5b0d8 and 6c4fab0. The old email address is |
|
I think we should do this even if GitHub itself doesn't support the mailmap file, as it will still apply to local |
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Good idea! I added your suggested changes. |
|
Thanks @amyreese for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-104002 is a backport of this pull request to the 3.11 branch. |
I changed my name last year, and would like to update my name in the acknowledgements and git history accordingly. git-mailmap reference: https://git-scm.com/docs/gitmailmap (cherry picked from commit 4b10ecc) Co-authored-by: Amethyst Reese <amethyst@n7.gg> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
…104002) Update name in acknowledgements and add mailmap (GH-103696) I changed my name last year, and would like to update my name in the acknowledgements and git history accordingly. git-mailmap reference: https://git-scm.com/docs/gitmailmap (cherry picked from commit 4b10ecc) Co-authored-by: Amethyst Reese <amethyst@n7.gg> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
Since we've now started down this road, there may be other contributors who would like to be similarly added here, though in most cases we should get direct confirmation from the contributor before adding them. There are also some defunct email addresses in the very long history of the repository, and mapping them to current addresses might be nice. We also need to edit |
* main: (26 commits) pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030) pythongh-104036: Fix direct invocation of test_typing (python#104037) pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761) pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897) Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021) pythongh-88496: Fix IDLE test hang on macOS (python#104025) Improve int test coverage (python#104024) pythongh-88773: Added teleport method to Turtle library (python#103974) pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017) pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014) pythongh-103977: compile re expressions in platform.py only if required (python#103981) pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004) Replace Netlify with Read the Docs build previews (python#103843) Update name in acknowledgements and add mailmap (python#103696) pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927) Remove non-existing tools from Sundry skiplist (python#103991) pythongh-103793: Defer formatting task name (python#103767) pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933) pythongh-103636: issue warning for deprecated calendar constants (python#103833) Various small fixes to dis docs (python#103923) ...
I changed my name last year, and would like to update my name in the acknowledgements and git history accordingly.
git-mailmap reference: https://git-scm.com/docs/gitmailmap