Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes #104014

Merged
merged 2 commits into from
Apr 30, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 30, 2023

@AlexWaygood AlexWaygood requested a review from hugovk April 30, 2023 14:51
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 30, 2023
@AlexWaygood AlexWaygood added skip news 3.12 bugs and security fixes labels Apr 30, 2023
@@ -493,6 +493,7 @@ def test_format(self):
class CalendarTestCase(unittest.TestCase):

def test_deprecation_warning(self):
warnings.resetwarnings()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we using self.assertWarns?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a reason not to use self.assertWarns. I just made the minimal change to fix the issue. Looking through the previous PR, it doesn't look like using assertWarns(Regex) was suggested, so the contributor may not have been aware of it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch to assertWarnsRegex, then we don't have to do all this manual manipulation of the warnings machinery.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sounds good

@AlexWaygood AlexWaygood enabled auto-merge (squash) April 30, 2023 15:30
@AlexWaygood AlexWaygood self-assigned this Apr 30, 2023
@AlexWaygood AlexWaygood merged commit 7d3931e into python:main Apr 30, 2023
@AlexWaygood AlexWaygood deleted the calendar-test branch April 30, 2023 16:35
carljm added a commit to carljm/cpython that referenced this pull request May 1, 2023
* main: (26 commits)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  pythongh-88773: Added teleport method to Turtle library (python#103974)
  pythongh-104015: Fix direct invocation of `test_dataclasses` (python#104017)
  pythongh-104012: Ensure test_calendar.CalendarTestCase.test_deprecation_warning consistently passes (python#104014)
  pythongh-103977: compile re expressions in platform.py only if required (python#103981)
  pythongh-98003: Inline call frames for CALL_FUNCTION_EX (pythonGH-98004)
  Replace Netlify with Read the Docs build previews (python#103843)
  Update name in acknowledgements and add mailmap (python#103696)
  pythongh-82054: allow test runner to split test_asyncio to execute in parallel by sharding. (python#103927)
  Remove non-existing tools from Sundry skiplist (python#103991)
  pythongh-103793: Defer formatting task name (python#103767)
  pythongh-87092: change assembler to use instruction sequence instead of CFG (python#103933)
  pythongh-103636: issue warning for deprecated calendar constants (python#103833)
  Various small fixes to dis docs (python#103923)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_calendar fails on Azure Pipelines
3 participants