Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Robot class tests #128

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Add Robot class tests #128

merged 8 commits into from
Jul 26, 2023

Conversation

sea-bass
Copy link
Owner

@sea-bass sea-bass commented Jul 23, 2023

This PR adds unit tests to the Robot class, and fixes a handful of issues in doing so.

I also took the liberty of

  • Moving some test files around (one of them was sitting with the source code)
  • Using pytest.warns to reduce the number of warnings produced by running the whole pyrobosim test suite.

image

Closes #93

@ibrahiminfinite
Copy link
Collaborator

Maybe we should pull out the world object outside as a non optional argument called map
Rest of the config can be optional. I feel that would make for a more intuitive API.
What do you think @sea-bass ?

@sea-bass
Copy link
Owner Author

Maybe we should pull out the world object outside as a non optional argument called map Rest of the config can be optional. I feel that would make for a more intuitive API. What do you think @sea-bass ?

That seems reasonable (it also makes the switch from world/grid easier) -- but not in this PR, if that's OK?

@ibrahiminfinite
Copy link
Collaborator

Yeah, definitely not in this PR.

@sea-bass sea-bass merged commit 68c97cb into main Jul 26, 2023
5 checks passed
@sea-bass sea-bass deleted the add-robot-tests branch July 26, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for Robot class
2 participants