sonic-wpasupplicant changes for PAC #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2024
|
Below are the associated PRs for this functionality. #88 HLD PR is below we will raise the remaining functionality in new PRs asap. |
|
/azpw run Azure |
|
/AzurePipelines run Azure |
|
No pipelines are associated with this pull request. |
|
@jeff-yin @ridahanif96 pls help review |
|
/azpw run Azure |
|
/AzurePipelines run Azure |
|
No pipelines are associated with this pull request. |
muhammadalihussnain
approved these changes
Aug 16, 2024
muhammadalihussnain
approved these changes
Aug 16, 2024
| @@ -82,6 +85,9 @@ enum { RADIUS_ATTR_USER_NAME = 1, | |||
| RADIUS_ATTR_ACCT_OUTPUT_GIGAWORDS = 53, | |||
| RADIUS_ATTR_EVENT_TIMESTAMP = 55, | |||
| RADIUS_ATTR_EGRESS_VLANID = 56, | |||
| #ifdef CONFIG_SONIC_RADIUS | |||
There was a problem hiding this comment.
Does this need to be in the middle? can't we move all new enums at the end?
| @@ -1728,3 +1751,420 @@ int radius_gen_session_id(u8 *id, size_t len) | |||
| */ | |||
| return os_get_random(id, len); | |||
| } | |||
|
|
|||
| #ifdef CONFIG_SONIC_RADIUS | |||
|
|
|||
There was a problem hiding this comment.
Can this SONiC specific code changes be moved to new file or patch file?
sutharsansr
approved these changes
Sep 30, 2024
venkatmahalingam
approved these changes
Oct 1, 2024
|
@Pterosaur code PR has been approved by PENS WG members, pls help merge |
adyeung
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The PAC functionality uses radius client that is in wpa supplicant for both 802.1X and MAB. These changes are done to achieve the same.
How I did it
How to verify it