Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in HOSTAPD to Support PAC #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vijaya-ops
Copy link

Why I did it
These changes are required to support PAC functionality to interact with 802.1X.

How I did it

How to verify it

@vijaya-ops
Copy link
Author

Below are the associated PRs for this functionality.

#88
#89
#90
#91
sonic-net/sonic-utilities#3265
sonic-net/sonic-swss-common#871

HLD PR is below
sonic-net/SONiC#1655

we will raise the remaining functionality in new PRs asap.

@vijaya-ops
Copy link
Author

/azpw run Azure

@mssonicbld
Copy link

/AzurePipelines run Azure

Copy link

No pipelines are associated with this pull request.

@adyeung
Copy link

adyeung commented Aug 7, 2024

@jeff-yin @ridahanif96 pls help review

@vijaya-ops
Copy link
Author

/azpw run Azure

@mssonicbld
Copy link

/AzurePipelines run Azure

Copy link

No pipelines are associated with this pull request.

Copy link

@muhammadalihussnain muhammadalihussnain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Looks Fine. Rerun or push again the code to pass the failed checks

@@ -176,8 +176,10 @@ static void hostapd_clear_old(struct hostapd_iface *iface)
* allow them to use the BSS anymore.
*/
for (j = 0; j < iface->num_bss; j++) {
#ifndef CONFIG_SONIC_HOSTAPD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design mentions that the hostapd receive packets directly when the mode is configured as MAB. Can you please help with the APIs for that functionality?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't get the question. The hostapd doesn't or never communicates with MAB directly. It communicates only with PACD. Similarly MAB communicates only with PACD. Can you please point to the section in the design document, if it is mentioned.. will correct the same.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my bad. Somehow I remember seeing that & wanted to check

@@ -176,8 +176,10 @@ static void hostapd_clear_old(struct hostapd_iface *iface)
* allow them to use the BSS anymore.
*/
for (j = 0; j < iface->num_bss; j++) {
#ifndef CONFIG_SONIC_HOSTAPD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my bad. Somehow I remember seeing that & wanted to check

@@ -33,21 +40,28 @@
#pragma pack(push, 1)
#endif /* _MSC_VER */

#if 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this code is not required, please remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants