HOSTPAD driver changes for PAC #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Below are the associated PRs for this functionality. #88 HLD PR is below we will raise the remaining functionality in new PRs asap. |
This was referenced Apr 8, 2024
|
/azpw run Azure |
|
/AzurePipelines run Azure |
|
No pipelines are associated with this pull request. |
|
@jeff-yin @ridahanif96 pls help review |
|
/azpw run Azure |
|
/AzurePipelines run Azure |
Ali Hussain from xFlow will review these PRs |
sutharsansr
approved these changes
Sep 30, 2024
| fprintf(stderr, "socket failed [%s]\n", strerror(errno)); | ||
| return -1; | ||
| } | ||
| printf("Created a socket with fd: %d\n", fd); |
There was a problem hiding this comment.
Do we need printfs in this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
These changes are required to support PAC functionality to sonic-wpasupplicant driver.
How I did it
How to verify it