RCAL-490 #676
Merged
RCAL-490 #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 63.74% 63.69% -0.05%
==========================================
Files 78 78
Lines 4115 4104 -11
==========================================
- Hits 2623 2614 -9
+ Misses 1492 1490 -2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
schlafly
reviewed
Apr 13, 2023
5 tasks
WilliamJamieson
force-pushed
the
refactor/remove_stdatamodels
branch
from
a812e57
to
580e0ea
Compare
|
Passes regression tests, see: https://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/132/ |
schlafly
approved these changes
Apr 18, 2023
mairanteodoro
pushed a commit
to mairanteodoro/romancal
that referenced
this pull request
Apr 18, 2023
This was referenced Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-490
Together with spacetelescope/stpipe#91, this PR will remove the
romancaldependency onstdatamodels.This is a result of the use of the
stdatamodels.s3_utilsin bothstpipeand here inromancal. However, theromancalusage ofs3_utilsis entirely the result of copying test fixtures fromjwsttoromancalduring its setup, and there is actual usage of these fixtures byromancal. Thestpipeusage ofs3_utilscan be eliminated ass3_utilsis unused byjwstandromancal. @eslavich can provide further details.Checklist
CHANGES.rstunder the corresponding subsection