-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stdatamodels
dependency
#91
Remove stdatamodels
dependency
#91
Conversation
57adcb4
to
a76ec43
Compare
The JWST failures are expected, spacetelescope/jwst#7542 needs to be merged in order for that to pass. |
a76ec43
to
64fd359
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 54.03% 54.16% +0.12%
==========================================
Files 25 25
Lines 3046 3024 -22
==========================================
- Hits 1646 1638 -8
+ Misses 1400 1386 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
64fd359
to
bc755f6
Compare
romancal
has a dependency ofstdatamodels
; however, there should not be a dependency of the Roman pipeline on JWST pipeline specific packages.The dependency is due to the
stdatamodels.s3_utils
module, which is a thing wrapper of the now unsupportedstsci-aws-utils
package. The introduction ofs3_utils
was largely due to an experiment to see if thejwst
pipeline could load reference files from S3. While this experiment was apparently successful, it was intended to be a one-off demonstration and has been largely unused since it completed. @eslavich can provide more details. Moreover, the implantation of S3 support requires client code injwst
andromancal
to know the source of input data (S3 or local filesystem) and handle the opening of internal files in a distinct fashion. Ideally the steps consuming reference files should not have to be aware of the origin of their files. Instead, CRDS, which provides these files to the steps, should handle this type of detail.