Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove s3_utils module #154

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Apr 11, 2023

The s3_utils module is no longer needed, see spacetelescope/stpipe#91 for details. This PR removes that module and cleans all the usages of s3_utils from stdatamodels.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@WilliamJamieson
Copy link
Contributor Author

WilliamJamieson commented Apr 11, 2023

The JWST failure is expected until spacetelescope/jwst#7542 is merged.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.25 ⚠️

Comparison is base (38e0edb) 65.22% compared to head (c6c00a9) 64.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   65.22%   64.98%   -0.25%     
==========================================
  Files         101       99       -2     
  Lines        5450     5377      -73     
==========================================
- Hits         3555     3494      -61     
+ Misses       1895     1883      -12     
Impacted Files Coverage Δ
src/stdatamodels/jwst/datamodels/conftest.py 100.00% <ø> (ø)
src/stdatamodels/jwst/datamodels/util.py 77.54% <100.00%> (-0.47%) ⬇️
src/stdatamodels/model_base.py 91.11% <100.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review April 11, 2023 20:48
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner April 11, 2023 20:48
@WilliamJamieson WilliamJamieson force-pushed the remove/s3_utils branch 2 times, most recently from 3700a93 to bf93465 Compare April 14, 2023 13:36
@hbushouse hbushouse merged commit 0e37e05 into spacetelescope:master Apr 17, 2023
@WilliamJamieson WilliamJamieson deleted the remove/s3_utils branch April 17, 2023 15:46
@zacharyburnett
Copy link
Collaborator

looks like romancal tests will also have to be changed: https://github.com/spacetelescope/romancal/actions/runs/4723206177/jobs/8378998152#step:10:121

@WilliamJamieson
Copy link
Contributor Author

WilliamJamieson commented Apr 17, 2023

looks like romancal tests will also have to be changed: spacetelescope/romancal/actions/runs/4723206177/jobs/8378998152#step:10:121

This has already been done: spacetelescope/romancal#676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants