feat!: integration of new transaction and output validation #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipr-za
force-pushed
the
philip-tx-validation-alternative
branch
2 times, most recently
from
ff0d275
to
0d8ee78
Compare
philipr-za
changed the title
philipr-za
force-pushed
the
philip-tx-validation-alternative
branch
4 times, most recently
from
1c5ae02
to
66fb85c
Compare
This PR cleans up and updates the new Output and Transaction validation strategies. @mikethetike provided the first draft of this new validation approach for both Outputs and Transactions but the work needed some love to fully integrate into the wallet code. Many edge cases were caught and some bigger changes are made in this PR to make the process reliable. Some major changes are: - Output validation now supports checking and reporting on number of confirmations - The Pending Transaction database table is fully removed and this process is now handled fully within the Outputs table - Validations are now triggered on receiving a new block from the base node rather than at an interval - Base node `query_deleted` call is updated to return the block data of where a deletion occured
philipr-za
force-pushed
the
philip-tx-validation-alternative
branch
from
66fb85c
to
3bbb0a2
Compare
stringhandler
approved these changes
Sep 20, 2021
stringhandler
added a commit
that referenced
this pull request
Oct 6, 2021
alternate approach to transaction validation (#3191) feat!: integration of new transaction and output validation (#3352) feat: update coinbase handling for new tx and output validation (#3383) refactor: use wallet connectivity in wallet services (#3391) refactor: mapping for deleted mmr position to height/hash for perf (#3394) feat: Fix reinstating CancelledInbound outputs and fix tests (#3400) chore: merge development into tx-validation2 and fix issues (#3417) Uncomment cucumber tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up and updates the new Output and Transaction validation strategies.
@mikethetike provided the first draft of this new validation approach for both Outputs and Transactions but the work needed some love to fully integrate into the wallet code. Many edge cases were caught and some bigger changes are made in this PR.
Some major changes are:
query_deletedcall is updated to return the block data of where a deletion occuredHow Has This Been Tested?
Tests provided/updated and manually