refactor: use wallet connectivity in wallet services #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generic substream was removed in order to more closely test RPC/yamux interaction but that was incorrect. The tests should have just been updated without removing the generic. This PR reintroduces them so that an RPC client mock can more easily be created.
sdbondi
force-pushed
the
wallet-protocol-use-connectivity
branch
2 times, most recently
from
cd7b74a
to
4050469
Compare
sdbondi
changed the title
- use wallet connectivity in broadcast protocol - remove base node update code in multiple services - use wallet connectivity in transaction validation protocol - use wallet connectivity in TXO validation task - update/fix tests
sdbondi
force-pushed
the
wallet-protocol-use-connectivity
branch
from
4050469
to
aeb1dcb
Compare
stringhandler
approved these changes
Sep 28, 2021
stringhandler
added a commit
that referenced
this pull request
Oct 6, 2021
alternate approach to transaction validation (#3191) feat!: integration of new transaction and output validation (#3352) feat: update coinbase handling for new tx and output validation (#3383) refactor: use wallet connectivity in wallet services (#3391) refactor: mapping for deleted mmr position to height/hash for perf (#3394) feat: Fix reinstating CancelledInbound outputs and fix tests (#3400) chore: merge development into tx-validation2 and fix issues (#3417) Uncomment cucumber tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WalletConnectivityServiceWalletConnectivityInterfaceIncludes commit from #3390
Motivation and Context
It is wallet connectivity service's responsibility to manage the base node connection. This PR
removes this responsibility out of the other components.
How Has This Been Tested?
Tests updated, Manually