refactor!: mapping for deleted mmr position to height/hash for perf #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add index to optimise query for block height from deleted mmr position - update query_deleted rpc call to use new call - check if database should be resynced to avoid confusion around db errors resulting from this change - exit code message showing help for a required db resync
sdbondi
force-pushed
the
core-height-db-index
branch
from
b5b3419
to
ed1b831
Compare
sdbondi
changed the title
stringhandler
added a commit
that referenced
this pull request
Oct 6, 2021
alternate approach to transaction validation (#3191) feat!: integration of new transaction and output validation (#3352) feat: update coinbase handling for new tx and output validation (#3383) refactor: use wallet connectivity in wallet services (#3391) refactor: mapping for deleted mmr position to height/hash for perf (#3394) feat: Fix reinstating CancelledInbound outputs and fix tests (#3400) chore: merge development into tx-validation2 and fix issues (#3417) Uncomment cucumber tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
db errors resulting from this change
Motivation and Context
Base node RPC call to
query_deletedis slowHow Has This Been Tested?
Updated blockchain db unit test, manually
BREAKING CHANGE: blockchain database will need to be resynced