Fix mac assignment in host add if provided a network.
#305
+10,812
−10,410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now properly distinguishes between networks and ips in every case. - Also handles the issue where using `host add` with an existing mac address caused a partial creation. The host was created, but the mac wasn't assigned as it was in used and not forced. This now fails early, although there is still a race condition as someone else may have allocated same address between our commands. There is currently no easy fix for this issue. Fixes #304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host addwith an existing mac address caused a partial creation. The host was created, but the mac wasn't assigned as it was in used and not forced. This now fails early, although there is still a race condition as someone else may have allocated same address between our commands. There is currently no easy fix for this issue.Fixes #304