Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mac assignment in host add if provided a network. #305

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix mac assignment in host add if provided a network. #305

merged 2 commits into from
Oct 9, 2024

Commits on Oct 8, 2024

  1. Fix mac assignment in host add if provided a network. 

      - Now properly distinguishes between networks and ips in every case.
  - Also handles the issue where using `host add` with an existing mac address caused a partial creation. The host was created, but the mac wasn't assigned as it was in used and not forced. This now fails early, although there is still a race condition as someone else may have allocated same address between our commands. There is currently no easy fix for this issue.

Fixes #304
    @terjekv
    terjekv committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c30e7e2 View commit details
    Browse the repository at this point in the history

  2. Update tests.

    @terjekv
    terjekv committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    56a9a3b View commit details
    Browse the repository at this point in the history