-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
…n#1827) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
A small update to the issue template that adds two things: - Since Gesture Handler 2 is closely integrated with Reanimated 2, I think it's a good idea to ask for its version explicitly. - Many issues are missing information about affected platforms which makes it harder to reproduce them. This PR adds a new section about affected platforms.
The `speed` option wasn't used in `openDrawer` and `closeDrawer` methods of `DrawerLayout`. This PR changes it, so it's passed further along to the method responsible for animating the drawer.
…e-mansion#1684) The handlers collection must have been modified in other place and the registry is the only class that modifies it. My guess is that the handler was dropped or removed from view and relevant method was called (asynchronously) causing the list to be modified while it was being iterated over. This PR locks the list while it's being modified or iterated over.
## Description This PR introduces a GitHub Actions bot used for triaging issues - checking an issue template, assigning labels, and checking for reproduction. Its purpose is to save time on reviewing and replying to incomplete issues. GitHub Actions code responsible for these actions can be found here: https://github.com/software-mansion-labs/swmansion-bot ## Changes - Added `needs-more-info.yml` - an action used for checking whether the issue template fields are filled - Added `needs-repro.yml` - an action used for checking whether the issue has a snack, GitHub repo, or a snippet of JavaScript/TypeScript code - Added `platforms.yml` - an action that assigns labels to user-selected platforms in the issue template - Added `close-when-stale.yml` - an action that closes an issue after 20 days of inactivity if it has the `Abandoned` label - Added `Missing info` & `Repro provided` label `needs-repro` action is triggered both by issue creation/edition and by comments. To prevent bot responses to old issues optional prop `check-issues-only-created-after` is set to 1 February 2022. This will assure that this action will be triggered only by comments on issues created after 2022-02-01.
At the moment, Reanimated event is rebuilt on every update which may cause a heavy performance hit in some cases. I believe that it's a leftover from pre-release Gesture Handler 2. This PR changes it so that the event will be rebuilt only when the gestures are reattached alleviating performance issues. Should fix software-mansion#1849.
Fix tvOS compilation errors by excluding unsupported parts of the code when building for it. Should fix software-mansion#1813.
Also deprecate Right/Left callbacks.
Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com> Co-authored-by: Krzysztof Piaskowy <krzychu2956@gmail.com>
…nsion#1863) Update React Native version in the Example app to 0.67.2 Make the app build on M1 Mac
- Add `runOnJS` modifier that makes callbacks of the event to be ran on the JS thread. - Modified `GestureDetector` to make use of this modifier and filter out unnecessary gestures when assigning them to the value read by the Reanimated hook. Gestures marked with `runOnJS` will now be registered for device events regardless of whether its callbacks are worklets or not. - Show error when trying to use gesture with only some of the callbacks marked as worklets without marking it with `runOnJS`.
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n#1874) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
software-mansion#1888) Change how device event subscriptions are removed to use `.remove()` on subscription itself instead of `DeviceEventEmitter.removeSubscription(...)`.
Add `tagMessage` function in utils that adds a standard tag to the message. Update existing `console.warn` and `console.error` invocations to make use of the new method.
"Abandoned" isn't applicable in case of issues.
Fixes TypeScript errors.
On web, apps would crash due to process property missing on global. This PR adds a check for it, so web apps work correctly.
`@testing-library/jest-native` and `@testing-library/react-native` are dev dependencies we cannot assume they will be always available. This PR makes jestUtils import fireEvent only when its available.
Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.1 to 3.0.4. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.7 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.7...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.25.0...v1.27.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In cases where `TouchableOpacity` and `TouchableNativeFeedback` were used together, but `TouchableOpacity` was placed first, the color of ripple animation would also be set to `transparent` for `TouchableNativeFeedback`. This PR changes the behavior of GestureHandlerButton so that it will set the color of ripple animation to [`android.R.attr.colorControlHighlight`](https://developer.android.com/reference/android/R.attr#colorControlHighlight) when no color is set by the user.
…oftware-mansion#1908) Fixes import of `StyleSheet` in `RNGestureHandlerButtonNativeComponent.js`.
…signed (software-mansion#1910) Fix related to comment [here](software-mansion#1844 (comment)) about `RNGestureHandlerButton` with `handlerType="NativeViewGestureHandler"` having missing testIDs when they were previously provided and assigned. The `testID` on the child being cloned within `createHandler` was being removed by the `testID` being set within the render function even the `testID` on the handler was not set. Now it will only assign a `testID` as a prop on the cloned element if a `testID` was provided to the handler.
This PR bumps `react-native-screens` in FabricExample to v3.13.1. Release notes: https://github.com/software-mansion/react-native-screens/releases/tag/3.13.1
Bump version to 2.3.1
…sion#1926) - Add manual gestures example based on tutorial from documentation - Fix Drag and drop example, had bug, onLongPress callback method should run on JSThread that can execute the `setState`
…on#1925) Update the example code for PanGestureHandler. It can now be easily copy-pasted as a whole.
- makes Gesture Handler's TouchableOpacity use native driver for animations by default - adds prop that allows to disable it
…package.json` (software-mansion#1917) Moves `jestUtils` to a separate package so it's not bundled when not actually used. This caused problems with `testing-library`, namely one of its dependencies - `ansi-styles`. It uses named capture groups in regex which is unsupported on Hermes. Fixes software-mansion#1913.
Bump version to 2.3.2
# Conflicts: # RNGestureHandler.podspec # android/build.gradle # package.json # src/handlers/createHandler.ts # src/utils.ts # tsconfig.json # yarn.lock
Hey @fluiddot 👋 I tried to test this using the patch but it looks like it only works if there's no Reanimated / Gesture Handler code being rendered. If there's some Reanimated / Gesture handler code being rendered It crashes with the following error
Maybe I'm missing something 😅 |
@geriux oh, that's probably caused by using a different version on the JS side, actually, I think I forgot to add to the patch the reference change to the dependency in the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@geriux heads up that I'm going to put the merge on hold until I open a PR in Gutenberg to update this dependency. I'll let you know when it's ready. Once that PR is ready to merge, we could start merging the different PRs. |
Sounds good! 👍 |
@geriux I created this PR for updating the package in the Gutenberg repository, so I'll start merging these changes as soon as possible. |
This PR updates the
wp-fork
branch with upstream version2.3.2
and applies the required changes to publish the Android library associated with the package.Since the PR contains a massive amount of changed files, in order to review this PR, it's better to compare the branch with the upstream repository and validate that we apply the same changes we have in
wp-fork
:2.3.2
version of upstream repositorywp-fork
NOTE: Once this PR is ready, we should also merge #19 so the diff showed in
wp-fork
doesn't contain the2.3.2
version changes.Testing instructions
packages/react-native-editor/android
project).