Merge master into feature/merge #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an instance of XenCenter is already running, the installer shows the `MsiRMFilesInUse` fragment. Pressing OK within that fragment with the `WixUIRMOption` property set to `UseRM` means that the `RMShutdownAndRestart` event kicks in at the end of the installation. This happens at the same time as the existing "Launch XenCenter" event (if the matching checkbox is checked), causing in the executable being started twice at about the same time. My guess is that the pipe system is not initialised at that point, and that's how we get two applications. To avoid this, this commit adds a new custom property: `XS_WixUIRMPressedOk`. This is set to `1` when the user clicks OK on the `WixUIRMOption`. It allows us to know whether or not that dialog was shown at all, as checking `WixUIRMOption` is not possible (it's already set to `UseRM` by default). By checking the value of this property we prevent the "Launch XenCenter" option to be shown if `MsiRMFilesInUse` was shown to the user (and they clicked OK). This applies both in case of a repair and an upgrade from a previous version. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
The text shown is the `Text` property of the `OptionalCheckBox` control Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Adds a new field in `SelectMultipleVMDestinationPage`: `AllSelectedTargets`. This new field contains a list of all hosts that have been selected. This way `ImportSelectHostPage` can check for each `Host` that has been selected individually and add more relevant messages Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…ngUpgradeWizardPrecheckPage` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
… `Check` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Also: - Remove unused `button_click` event handler in `AcceptEuaDialog` - Load EUAs within the `UpgradeRequiresEua` `Check` and removed the spinner from `AcceptEuaDialog` - Remove `_errors` from `AcceptEuaDialog` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Also: - Add `HostDoesNotHaveHotfixWarning` warning to EUA `Check` when necessary - Filter our `null` EUAs before passing them to the `Problem` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
- Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts - Group non-manual checks in same if block - Remove unused field in `EuaNotFoundProblem` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…ion` is null Applies to newly added EUA presence problem Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…and layout tweaks: - The checkbox should be above the credential textboxes. - Some controls were not aligned correctly. - Place the controls in tableLayout panels. Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
…vTPMs as OVF/OVA packages. Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…des to 8.2 CU1 or below Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…s are missing Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
CA-379402: Fix EUA check & add hotfix check to `HostMemoryPostUpgradeCheck`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Also update spacing of controls within the `CustomizeDlg` to take more advantage of the available space Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
…g with Wix installer Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
CA-376480, CA-374325, & CA-378489: Prevent two instances from starting after running installer; Add desktop shortcut option; Remove existing shortcuts
Miscellaneous fixes to vCPUs warnings
CP-43770: Removed images from the WLB credentials dialog (plus some refactoring and layout tweaks)
… Session constructors. Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
CitrixChris
approved these changes
Jul 12, 2023
danilo-delbusso
approved these changes
Jul 12, 2023
danilo-delbusso
added
2 approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.