-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into feature/merge #3171
Commits on Apr 21, 2023
-
CA-376480: Prevent two instances from starting after running installer
When an instance of XenCenter is already running, the installer shows the `MsiRMFilesInUse` fragment. Pressing OK within that fragment with the `WixUIRMOption` property set to `UseRM` means that the `RMShutdownAndRestart` event kicks in at the end of the installation. This happens at the same time as the existing "Launch XenCenter" event (if the matching checkbox is checked), causing in the executable being started twice at about the same time. My guess is that the pipe system is not initialised at that point, and that's how we get two applications. To avoid this, this commit adds a new custom property: `XS_WixUIRMPressedOk`. This is set to `1` when the user clicks OK on the `WixUIRMOption`. It allows us to know whether or not that dialog was shown at all, as checking `WixUIRMOption` is not possible (it's already set to `UseRM` by default). By checking the value of this property we prevent the "Launch XenCenter" option to be shown if `MsiRMFilesInUse` was shown to the user (and they clicked OK). This applies both in case of a repair and an upgrade from a previous version. Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 15fcc02 - Browse repository at this point
Copy the full SHA 15fcc02View commit details -
Remove unused patch of
WIXUI_EXITDIALOGOPTIONALTEXT
The text shown is the `Text` property of the `OptionalCheckBox` control Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for f01c48c - Browse repository at this point
Copy the full SHA f01c48cView commit details -
CA-374325: Add shortcut checkbox to custom setup dialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 54c34b9 - Browse repository at this point
Copy the full SHA 54c34b9View commit details
Commits on Jun 16, 2023
-
Move
_ovfVCpusCount.Clear
outside content check loopSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for a2a5ae0 - Browse repository at this point
Copy the full SHA a2a5ae0View commit details -
Reset
ovfMaxVCpusCount
when a new OVF is selectedSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 084215f - Browse repository at this point
Copy the full SHA 084215fView commit details
Commits on Jun 19, 2023
-
Update warning messages for host selection when importing VM appliance
Adds a new field in `SelectMultipleVMDestinationPage`: `AllSelectedTargets`. This new field contains a list of all hosts that have been selected. This way `ImportSelectHostPage` can check for each `Host` that has been selected individually and add more relevant messages Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for eb0636f - Browse repository at this point
Copy the full SHA eb0636fView commit details
Commits on Jun 26, 2023
-
Enable multiple
IXenObject
s to be associated with aCheck
instanceSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 34eb5ff - Browse repository at this point
Copy the full SHA 34eb5ffView commit details -
CP-41573: Add helper function to fetch host EUA
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for e265a1f - Browse repository at this point
Copy the full SHA e265a1fView commit details -
CP-41573: Add
UpgradeRequiresEua
andEuaNotAcceptedProblem
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 49b8f8e - Browse repository at this point
Copy the full SHA 49b8f8eView commit details -
CP-41573: Add
UpgradeRequiresEua
as a permanent check to the `Rolli……ngUpgradeWizardPrecheckPage` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for f707b0d - Browse repository at this point
Copy the full SHA f707b0dView commit details -
CP-41573: Improve comparison logic for problems
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 5f56950 - Browse repository at this point
Copy the full SHA 5f56950View commit details -
CP-41573: Move EUA precheck after hotfixes
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for f03c1cc - Browse repository at this point
Copy the full SHA f03c1ccView commit details -
CP-41573: Check for presence of valid URI within
UpgradeRequiresEUA
…… `Check` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for de6372f - Browse repository at this point
Copy the full SHA de6372fView commit details -
CP-41573: Add blocking problem if POST82X hosts cannot fetch the EUA
Also: - Remove unused `button_click` event handler in `AcceptEuaDialog` - Load EUAs within the `UpgradeRequiresEua` `Check` and removed the spinner from `AcceptEuaDialog` - Remove `_errors` from `AcceptEuaDialog` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for c463601 - Browse repository at this point
Copy the full SHA c463601View commit details -
CP-41573: Add
10
padding toAcceptEuaDialog
contentSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for b7a20d5 - Browse repository at this point
Copy the full SHA b7a20d5View commit details -
CP-41573: Set
AcceptButton
andCancelButton
forAcceptEuaDialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 927c5b1 - Browse repository at this point
Copy the full SHA 927c5b1View commit details -
CP-41573: Use wizard page as a parent of
AcceptEuaDialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for ffbf8e3 - Browse repository at this point
Copy the full SHA ffbf8e3View commit details -
CP-41573: Use existing generic message for
EuaNotFoundProblem
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for c0f849e - Browse repository at this point
Copy the full SHA c0f849eView commit details -
CP-41573: Make
AcceptEuaDialog
resizableSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 58be7ff - Browse repository at this point
Copy the full SHA 58be7ffView commit details -
CP-41923: Update RPU005 to version 5.0
Also: - Add `HostDoesNotHaveHotfixWarning` warning to EUA `Check` when necessary - Filter our `null` EUAs before passing them to the `Problem` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 6ce22f7 - Browse repository at this point
Copy the full SHA 6ce22f7View commit details -
CP-41573: Apply code review suggestions
- Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts - Group non-manual checks in same if block - Remove unused field in `EuaNotFoundProblem` Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 06ab09e - Browse repository at this point
Copy the full SHA 06ab09eView commit details -
CP-41573: Refresh pre-checks once
EuaNotAcceptedProblem
is fixedSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 594db56 - Browse repository at this point
Copy the full SHA 594db56View commit details -
CP-41573: Do not attempt problem reversion if `SolutionAction.Connect…
…ion` is null Applies to newly added EUA presence problem Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 1e78d69 - Browse repository at this point
Copy the full SHA 1e78d69View commit details
Commits on Jun 29, 2023
-
CP-43770: Removed images from the WLB credentials dialog. Minor text …
…and layout tweaks: - The checkbox should be above the credential textboxes. - Some controls were not aligned correctly. - Place the controls in tableLayout panels. Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for cfd0216 - Browse repository at this point
Copy the full SHA cfd0216View commit details -
Refactoring to avoid repetition of calculations.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 57c2cb9 - Browse repository at this point
Copy the full SHA 57c2cb9View commit details
Commits on Jul 3, 2023
-
CA-377017: Improved message shown when attempting to export VMs with …
…vTPMs as OVF/OVA packages. Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for d437428 - Browse repository at this point
Copy the full SHA d437428View commit details -
Remove backing field for
AllSelectedTargets
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for b433877 - Browse repository at this point
Copy the full SHA b433877View commit details -
Update wording of vCPUs count warnings in
ImportWizard
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for dc747fe - Browse repository at this point
Copy the full SHA dc747feView commit details -
CA-379402: Do not return
Problem
s if the EUA check is run for upgra……des to 8.2 CU1 or below Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 6eb09cb - Browse repository at this point
Copy the full SHA 6eb09cbView commit details -
Prevent
HostMemoryPostUpgradeCheck
from running if required hotfixe……s are missing Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for eba3305 - Browse repository at this point
Copy the full SHA eba3305View commit details
Commits on Jul 4, 2023
-
Ensure
CanRun
is called before adding EUA check to precheks listSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 4e59f26 - Browse repository at this point
Copy the full SHA 4e59f26View commit details -
Ensure
PrepareToUpgradeCheck
is run first in the manual upgrade blockSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for d2424ea - Browse repository at this point
Copy the full SHA d2424eaView commit details -
Merge pull request #3167 from danilo-delbusso/bug/CA-379402_eua
CA-379402: Fix EUA check & add hotfix check to `HostMemoryPostUpgradeCheck`
Configuration menu - View commit details
-
Copy full SHA for b7eff2d - Browse repository at this point
Copy the full SHA b7eff2dView commit details
Commits on Jul 10, 2023
-
Improve wording for
IMPORT_WIZARD_CPUS_COUNT_MISMATCH_POOL
warningSigned-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for a08ed18 - Browse repository at this point
Copy the full SHA a08ed18View commit details -
CA-374325: Move shortcut to last page
Also update spacing of controls within the `CustomizeDlg` to take more advantage of the available space Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 715f873 - Browse repository at this point
Copy the full SHA 715f873View commit details -
CA-378489: Remove all remnants of previous installation when upgradin…
…g with Wix installer Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 1d8391c - Browse repository at this point
Copy the full SHA 1d8391cView commit details -
Merge pull request #3136 from danilo-delbusso/dev/start-twice-CA-376480
CA-376480, CA-374325, & CA-378489: Prevent two instances from starting after running installer; Add desktop shortcut option; Remove existing shortcuts
Configuration menu - View commit details
-
Copy full SHA for d3004bf - Browse repository at this point
Copy the full SHA d3004bfView commit details -
Merge pull request #3160 from danilo-delbusso/dev/vcpus-warnings
Miscellaneous fixes to vCPUs warnings
Configuration menu - View commit details
-
Copy full SHA for 33d0b72 - Browse repository at this point
Copy the full SHA 33d0b72View commit details
Commits on Jul 11, 2023
-
Merge pull request #3166 from kc284/wlb_images
CP-43770: Removed images from the WLB credentials dialog (plus some refactoring and layout tweaks)
Configuration menu - View commit details
-
Copy full SHA for 00668e8 - Browse repository at this point
Copy the full SHA 00668e8View commit details
Commits on Jul 12, 2023
-
Updated SDK to v23.15.0. Updated code as this drop deprecates certain…
… Session constructors. Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Configuration menu - View commit details
-
Copy full SHA for 387d030 - Browse repository at this point
Copy the full SHA 387d030View commit details