Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into feature/merge #3171

Merged
merged 40 commits into from
Jul 12, 2023
Merged

Merge master into feature/merge #3171

merged 40 commits into from
Jul 12, 2023

Commits on Apr 21, 2023

  1. CA-376480: Prevent two instances from starting after running installer

    When an instance of XenCenter is already running, the installer shows the `MsiRMFilesInUse` fragment. Pressing OK within that fragment with the `WixUIRMOption` property set to `UseRM` means that the `RMShutdownAndRestart` event kicks in at the end of the installation.
    
    This happens at the same time as the existing "Launch XenCenter" event (if the matching checkbox is checked), causing in the executable being started twice at about the same time. My guess is that the pipe system is not initialised at that point, and that's how we get two applications.
    
    To avoid this, this commit adds a new custom property: `XS_WixUIRMPressedOk`. This is set to `1` when the user clicks OK on the `WixUIRMOption`. It allows us to know whether or not that dialog was shown at all, as checking `WixUIRMOption` is not possible (it's already set to `UseRM` by default). By checking the value of this property we prevent the "Launch XenCenter" option to be shown if `MsiRMFilesInUse` was shown to the user (and they clicked OK). This applies both in case of a repair and an upgrade from a previous version.
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    15fcc02 View commit details
    Browse the repository at this point in the history
  2. Remove unused patch of WIXUI_EXITDIALOGOPTIONALTEXT

    The text shown is the `Text` property of the `OptionalCheckBox` control
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f01c48c View commit details
    Browse the repository at this point in the history
  3. CA-374325: Add shortcut checkbox to custom setup dialog

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    54c34b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Move _ovfVCpusCount.Clear outside content check loop

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a2a5ae0 View commit details
    Browse the repository at this point in the history
  2. Reset ovfMaxVCpusCount when a new OVF is selected

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    084215f View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Update warning messages for host selection when importing VM appliance

    Adds a new field in `SelectMultipleVMDestinationPage`: `AllSelectedTargets`.
    
    This new field contains a list of all hosts that have been selected. This way `ImportSelectHostPage` can check for each `Host` that has been selected individually and add more relevant messages
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    eb0636f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Enable multiple IXenObjects to be associated with a Check instance

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    34eb5ff View commit details
    Browse the repository at this point in the history
  2. CP-41573: Add helper function to fetch host EUA

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e265a1f View commit details
    Browse the repository at this point in the history
  3. CP-41573: Add UpgradeRequiresEua and EuaNotAcceptedProblem

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    49b8f8e View commit details
    Browse the repository at this point in the history
  4. CP-41573: Add UpgradeRequiresEua as a permanent check to the `Rolli…

    …ngUpgradeWizardPrecheckPage`
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f707b0d View commit details
    Browse the repository at this point in the history
  5. CP-41573: Improve comparison logic for problems

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5f56950 View commit details
    Browse the repository at this point in the history
  6. CP-41573: Move EUA precheck after hotfixes

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    f03c1cc View commit details
    Browse the repository at this point in the history
  7. CP-41573: Check for presence of valid URI within UpgradeRequiresEUA

    … `Check`
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    de6372f View commit details
    Browse the repository at this point in the history
  8. CP-41573: Add blocking problem if POST82X hosts cannot fetch the EUA

    Also:
    - Remove unused `button_click` event handler in `AcceptEuaDialog`
    - Load EUAs within the `UpgradeRequiresEua` `Check` and removed the spinner from `AcceptEuaDialog`
    - Remove `_errors` from `AcceptEuaDialog`
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c463601 View commit details
    Browse the repository at this point in the history
  9. CP-41573: Add 10 padding to AcceptEuaDialog content

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    b7a20d5 View commit details
    Browse the repository at this point in the history
  10. CP-41573: Set AcceptButton and CancelButton for AcceptEuaDialog

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    927c5b1 View commit details
    Browse the repository at this point in the history
  11. CP-41573: Use wizard page as a parent of AcceptEuaDialog

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ffbf8e3 View commit details
    Browse the repository at this point in the history
  12. CP-41573: Use existing generic message for EuaNotFoundProblem

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c0f849e View commit details
    Browse the repository at this point in the history
  13. CP-41573: Make AcceptEuaDialog resizable

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    58be7ff View commit details
    Browse the repository at this point in the history
  14. CP-41923: Update RPU005 to version 5.0

    Also:
    - Add `HostDoesNotHaveHotfixWarning` warning to EUA `Check` when necessary
    - Filter our `null` EUAs before passing them to the `Problem`
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    6ce22f7 View commit details
    Browse the repository at this point in the history
  15. CP-41573: Apply code review suggestions

    - Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts
    - Group non-manual checks in same if block
    - Remove unused field in `EuaNotFoundProblem`
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    06ab09e View commit details
    Browse the repository at this point in the history
  16. CP-41573: Refresh pre-checks once EuaNotAcceptedProblem is fixed

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    594db56 View commit details
    Browse the repository at this point in the history
  17. CP-41573: Do not attempt problem reversion if `SolutionAction.Connect…

    …ion` is null
    
    Applies to newly added EUA presence problem
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso authored and kc284 committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    1e78d69 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. CP-43770: Removed images from the WLB credentials dialog. Minor text …

    …and layout tweaks:
    
    - The checkbox should be above the credential textboxes.
    - Some controls were not aligned correctly.
    - Place the controls in tableLayout panels.
    
    Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
    kc284 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    cfd0216 View commit details
    Browse the repository at this point in the history
  2. Refactoring to avoid repetition of calculations.

    Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
    kc284 committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    57c2cb9 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. CA-377017: Improved message shown when attempting to export VMs with …

    …vTPMs as OVF/OVA packages.
    
    Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
    kc284 committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    d437428 View commit details
    Browse the repository at this point in the history
  2. Remove backing field for AllSelectedTargets

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b433877 View commit details
    Browse the repository at this point in the history
  3. Update wording of vCPUs count warnings in ImportWizard

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    dc747fe View commit details
    Browse the repository at this point in the history
  4. CA-379402: Do not return Problems if the EUA check is run for upgra…

    …des to 8.2 CU1 or below
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6eb09cb View commit details
    Browse the repository at this point in the history
  5. Prevent HostMemoryPostUpgradeCheck from running if required hotfixe…

    …s are missing
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    eba3305 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Ensure CanRun is called before adding EUA check to precheks list

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4e59f26 View commit details
    Browse the repository at this point in the history
  2. Ensure PrepareToUpgradeCheck is run first in the manual upgrade block

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d2424ea View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3167 from danilo-delbusso/bug/CA-379402_eua

    CA-379402: Fix EUA check & add hotfix check to `HostMemoryPostUpgradeCheck`
    kc284 authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    b7eff2d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Improve wording for IMPORT_WIZARD_CPUS_COUNT_MISMATCH_POOL warning

    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a08ed18 View commit details
    Browse the repository at this point in the history
  2. CA-374325: Move shortcut to last page

    Also update spacing of controls within the `CustomizeDlg` to take more advantage of the available space
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    715f873 View commit details
    Browse the repository at this point in the history
  3. CA-378489: Remove all remnants of previous installation when upgradin…

    …g with Wix installer
    
    Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
    danilo-delbusso committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    1d8391c View commit details
    Browse the repository at this point in the history
  4. Merge pull request #3136 from danilo-delbusso/dev/start-twice-CA-376480

    CA-376480, CA-374325, & CA-378489: Prevent two instances from starting after running installer; Add desktop shortcut option; Remove existing shortcuts
    kc284 authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    d3004bf View commit details
    Browse the repository at this point in the history
  5. Merge pull request #3160 from danilo-delbusso/dev/vcpus-warnings

    Miscellaneous fixes to vCPUs warnings
    kc284 authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    33d0b72 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Merge pull request #3166 from kc284/wlb_images

    CP-43770: Removed images from the WLB credentials dialog (plus some refactoring and layout tweaks)
    kc284 authored Jul 11, 2023
    Configuration menu
    Copy the full SHA
    00668e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Updated SDK to v23.15.0. Updated code as this drop deprecates certain…

    … Session constructors.
    
    Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
    kc284 committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    387d030 View commit details
    Browse the repository at this point in the history