Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSD-1702: responsive grid system #1591

Open
wants to merge 212 commits into
base: breakpoints-grid-feature-branch
Choose a base branch
from
Open

DSD-1702: responsive grid system #1591

wants to merge 212 commits into from

Conversation

bigfishdesign13
Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 commented May 6, 2024 •
edited
Loading

Fixes JIRA ticket DSD-1702

This PR does the following:

  • Updates the Template component to implement a new responsive grid system.
  • Updates the docs for the Template component to explain how the new responsive grid system will work and how to use the legacy "grid" layout.
  • Adds and exports the responsiveGutters and responsiveSpacing data objects to make available to consuming apps.
  • Adds the Responsive Grid page to the Style Guide.

How has this been tested?

  • local Storybook

Accessibility concerns or updates

  • n/a

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

EdwinGuzman and others added 30 commits April 12, 2024 16:13
@EdwinGuzman
Updating vite and other related packages
72f284f
@EdwinGuzman
fixing storybook issue
8629425
@EdwinGuzman
Storybook 8
48e79a2
@EdwinGuzman
adding missing file?
395e76f
@EdwinGuzman
storybook argtypes
9abf6ba
@EdwinGuzman
main change
997a54a
@EdwinGuzman
Merge branch 'development' into DSD-1766/npm-package-update
3d9e209 
* development:
  better ts formatting
  added docs for Visited State Patterns
  changelog updates
  updated color styles for NoBrand button
  updated placeholder for search field
@EdwinGuzman
Minor update
e66ff4a
@EdwinGuzman
Changelog and better storybook html defaults
ac93b77
@EdwinGuzman
Merge branch 'development' into DSD-1766/npm-package-update
ce9fbe0 
* development:
  updates based on comments
  formatting
  better layout for Icon examples
@EdwinGuzman
forgot about downshift which is no longer used
b305062
@EdwinGuzman
Updates based on feedback
8d2ed81
@EdwinGuzman
merging and fixing conflicts from development
900ad28
@EdwinGuzman
Adding back ts
7154431
@EdwinGuzman
package.json update
f1bc663
@EdwinGuzman
Merge pull request #1585 from NYPL/development
e83e2cd 
Release 3.1.1
@bigfishdesign13
adjusted header styles
b295fd7
@bigfishdesign13
package-lock
e10a9ef
@EdwinGuzman
merging and fixing conflicts from development
6741abe
@7emansell
Component, tests, stories added
5b05b59
@7emansell
Name change to Confirmation
740525a
@7emansell
Changelog
88b2d4d
@7emansell
Clarifying usage in docs
38cdf89
@7emansell
Commenting more in Modal
4e0ed99
@7emansell
More typos
3f92bb9
@7emansell
More and more typos
813dd7e
@7emansell
Rearranging props
add7440
@7emansell
Hard set of default to fix onClose
380bc86
@7emansell
Edwin docs fixes
e9956eb
@7emansell
Release candidate, making type prop explicit
eaaaceb
EdwinGuzman and others added 28 commits June 21, 2024 12:39
@EdwinGuzman
Merging and fixing conflicts from development
f636ebc
@EdwinGuzman
Merge pull request #1624 from NYPL/DSD-1751/slider-interaction-tests
75340ac 
DSD-1751: Adding interaction tests for Slider component
@oliviawongnyc
Merge branch 'development' into DSD-1740/close-dropdown-multiselect
262a5b1
@oliviawongnyc
Updates per PR feedback
0bc9a58
@7emansell
Tests and changelogs
e3c6559
@7emansell
Adding type and example in storybook
b6cbb65
@oliviawongnyc
Cleans up
f709a00
@oliviawongnyc
CHANGELOG cleanup
d3e45dd
@oliviawongnyc
Merge pull request #1607 from NYPL/DSD-1740/close-dropdown-multiselect
bae5120 
DSD-1740/close dropdown multiselect
@oliviawongnyc
More updates per feedback
78a7b94
@oliviawongnyc
Updates snapshot
9b03e4b
@oliviawongnyc
Separates handleEvent function into two
4cda43b
@7emansell
Corrected colors and changelogs
dc60e5b
@7emansell
Merge branch 'development' into DSD-1795/breadcrumbs-dc-variant
b254c18
@7emansell
Alphabetized, focus color updated
1e31465
@7emansell
Adding more tests with the email and radio button fields
6f395c6
@7emansell
Merge branch 'development' into DSD-1746/feedback-interaction-tests
2cd9292
@oliviawongnyc
Updates docs per feedback
1c58b68
@oliviawongnyc
Merge pull request #1620 from NYPL/DSD-1787/close-multiselect-on-blur
970f14c 
DSD-1740: Adds ability to close MultiSelect on blur
@7emansell
Merge branch 'development' into DSD-1746/feedback-interaction-tests
f600cbb
@7emansell
alphabetize fully
bbd6588
@7emansell
Merge branch 'development' into DSD-1795/breadcrumbs-dc-variant
87314c7
@7emansell
Merge pull request #1628 from NYPL/DSD-1746/feedback-interaction-tests
40e9625 
DSD-1746: FeedbackBox interaction tests
@7emansell
Merge branch 'development' into DSD-1795/breadcrumbs-dc-variant
4892697
@7emansell
Merge pull request #1629 from NYPL/DSD-1795/breadcrumbs-dc-variant
0340dda 
DSD-1795: Breadcrumbs Digital Collections variant
@EdwinGuzman
Merging and fixing conflicts from development
532b399
@EdwinGuzman
Merge pull request #1625 from NYPL/no_ref/jest-routine-package-update
ff5428d 
jest routing npm package update
@bigfishdesign13
merge from development branch
793283a
@charmingduchess charmingduchess removed their request for review July 30, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hokei hokei hokei left review comments

@EdwinGuzman EdwinGuzman EdwinGuzman requested changes

@7emansell 7emansell Awaiting requested review from 7emansell

@dgcohen dgcohen Awaiting requested review from dgcohen

@jackiequach jackiequach Awaiting requested review from jackiequach

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

@isastettler isastettler Awaiting requested review from isastettler

@nypl-wluisi nypl-wluisi Awaiting requested review from nypl-wluisi

Assignees
No one assigned
Labels
Needs Review Pull requests that are ready for peer review. x2 This PR needs at least two approvals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigfishdesign13 @EdwinGuzman @hokei @7emansell @oliviawongnyc