refactor: Bootstrap to AntD - Slider #13989

michael-s-molina · 2021-04-07T11:59:38Z

SUMMARY

Migrates the Slider component from Bootstrap to AntD
Creates a storybook entry for Slider
Removes ReactBootstrapSlider

PS: No tests were added because we don't add any custom behavior to the component. Relying on AntD tests.

@mihir174 I didn't found the Slider component in the North Star specification so I used AntD default, which I think fits very well with our theme. Let me know if we need to change it.

@rusackas @junlincc @pkdotson

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

1 - Execute all tests
2 - All tests should pass
3 - Additional testing can be done using Storybook

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-04-07T12:39:51Z

Codecov Report

Merging #13989 (797d4c7) into master (8b9c142) will increase coverage by 1.34%.
The diff coverage is 85.33%.

❗ Current head 797d4c7 differs from pull request most recent head 432f063. Consider uploading reports for the commit 432f063 to get more accurate results

@@            Coverage Diff             @@
##           master   #13989      +/-   ##
==========================================
+ Coverage   77.87%   79.22%   +1.34%     
==========================================
  Files         935      936       +1     
  Lines       47375    47409      +34     
  Branches     5964     5941      -23     
==========================================
+ Hits        36895    37561     +666     
+ Misses      10323     9721     -602     
+ Partials      157      127      -30

Flag	Coverage Δ
cypress	`56.06% <66.66%> (+5.29%)`	⬆️
javascript	`68.46% <78.26%> (+1.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts	`100.00% <ø> (ø)`
...src/dashboard/components/PropertiesModal/index.jsx	`85.61% <ø> (ø)`
...shboard/components/filterscope/FilterFieldItem.jsx	`100.00% <ø> (+50.00%)`	⬆️
...shboard/components/filterscope/FilterFieldTree.jsx	`66.66% <ø> (+22.22%)`	⬆️
...hboard/components/filterscope/FilterScopeModal.tsx	`75.00% <ø> (ø)`
...ard/components/filterscope/FilterScopeSelector.jsx	`87.67% <ø> (+85.61%)`	⬆️
...shboard/components/filterscope/FilterScopeTree.jsx	`70.00% <ø> (+20.00%)`	⬆️
...ponents/filterscope/renderFilterFieldTreeNodes.jsx	`90.00% <ø> (+90.00%)`	⬆️
...ponents/filterscope/renderFilterScopeTreeNodes.jsx	`86.66% <ø> (+86.66%)`	⬆️
...oard/components/nativeFilters/FilterBar/Header.tsx	`87.09% <0.00%> (ø)`
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9c142...432f063. Read the comment docs.

junlincc · 2021-04-08T17:43:10Z

@michael-s-molina this is awesome Michael! we are finally back on the migration.

junlincc · 2021-04-08T17:43:23Z

/testenv up

github-actions · 2021-04-08T18:02:53Z

@junlincc Ephemeral environment spinning up at http://35.167.16.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Steejay · 2021-04-08T18:18:29Z

looks good to me. cc @mihir174

suddjian

Nice! Good to see the migration continuing. We should probably remove the BootstrapSliderWrapper component as well.

michael-s-molina · 2021-04-08T19:51:25Z

Nice! Good to see the migration continuing. We should probably remove the BootstrapSliderWrapper component as well.

Strange.. the PR's description is stating that I removed the file. Maybe I forgot to commit? Anyway, I'll delete it. Thanks for catching that @suddjian!

michael-s-molina · 2021-04-09T12:42:27Z

@suddjian I was reviewing the code and turns out that:

BootstrapSliderWrapper/index.jsx was renamed to Slider/Slider.stories.tsx
BootstrapSliderWrapper.less was renamed to Slider/index.tsx

So they were in fact deleted 😄

suddjian

Looks good!

pkdotson

LGTM!

github-actions · 2021-04-13T00:26:56Z

Ephemeral environment shutdown and build artifacts deleted.

* master: fix: unable to apply logging format (#14074) refactor: Bootstrap to AntD - Slider (#13989) chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306) fix(listview): update listview feature flag (#13906) Add docs for configuring Docker Compose setup (#13961) feat: invalid password error message (Postgres) (#14038) fix: flacky test in test_update_dataset_item_w_override_columns (#14082) feat: Implement Celery SoftTimeLimit handling (#13740) feat: only send alert error emails to owners of the alert (#13862) feat: add descriptions to report emails (#13827) Make chart exclude itself from cross filtering (#14046) fix: fix bug when remove chart not removing it's related cross filter data (#14081) feat(native-filters): Add default first value to select filter (#13726) feat: Make async query JWT cookie domain configurable (#14007) fix: add exception to catch session not having JWT (#14036) # Conflicts: # superset-frontend/src/dashboard/actions/hydrate.js # superset/views/core.py

* master: (53 commits) test: Adds tests to the UndoRedoKeyListeners component (#13919) chore: Adds dataMask reducer to reducerIndex (#13951) test: Tests audit for the Dashboard FilterBar (#13916) fix: unable to apply logging format (#14074) refactor: Bootstrap to AntD - Slider (#13989) chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306) fix(listview): update listview feature flag (#13906) Add docs for configuring Docker Compose setup (#13961) feat: invalid password error message (Postgres) (#14038) fix: flacky test in test_update_dataset_item_w_override_columns (#14082) feat: Implement Celery SoftTimeLimit handling (#13740) feat: only send alert error emails to owners of the alert (#13862) feat: add descriptions to report emails (#13827) Make chart exclude itself from cross filtering (#14046) fix: fix bug when remove chart not removing it's related cross filter data (#14081) feat(native-filters): Add default first value to select filter (#13726) feat: Make async query JWT cookie domain configurable (#14007) fix: add exception to catch session not having JWT (#14036) Use consistent chart value (#14031) fix: Use superset generic db to catch external_metadata queries (#13974) ...

refactor: Bootstrap to AntD - Slider

432f063

pull-request-size bot added the size/M label Apr 7, 2021

rusackas added the design:review label Apr 7, 2021

junlincc added migration:library frontend:refactor Related to refactoring the frontend and removed migration:library labels Apr 8, 2021

suddjian requested changes Apr 8, 2021

View reviewed changes

michael-s-molina requested a review from suddjian April 9, 2021 12:42

suddjian approved these changes Apr 9, 2021

View reviewed changes

pkdotson approved these changes Apr 12, 2021

View reviewed changes

pkdotson merged commit 92a6692 into apache:master Apr 12, 2021

allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021

refactor: Bootstrap to AntD - Slider (apache#13989)

fd229a9

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021

refactor: Bootstrap to AntD - Slider (apache#13989)

faeb1d7

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Bootstrap to AntD - Slider #13989

refactor: Bootstrap to AntD - Slider #13989

michael-s-molina commented Apr 7, 2021 •

edited

Loading

codecov bot commented Apr 7, 2021 •

edited

Loading

junlincc commented Apr 8, 2021

junlincc commented Apr 8, 2021

github-actions bot commented Apr 8, 2021

Steejay commented Apr 8, 2021

suddjian left a comment

michael-s-molina commented Apr 8, 2021

michael-s-molina commented Apr 9, 2021

suddjian left a comment

pkdotson left a comment

github-actions bot commented Apr 13, 2021

refactor: Bootstrap to AntD - Slider #13989

refactor: Bootstrap to AntD - Slider #13989

Conversation

michael-s-molina commented Apr 7, 2021 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

codecov bot commented Apr 7, 2021 • edited Loading

Codecov Report

junlincc commented Apr 8, 2021

junlincc commented Apr 8, 2021

github-actions bot commented Apr 8, 2021

Steejay commented Apr 8, 2021

suddjian left a comment

Choose a reason for hiding this comment

michael-s-molina commented Apr 8, 2021

michael-s-molina commented Apr 9, 2021

suddjian left a comment

Choose a reason for hiding this comment

pkdotson left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 13, 2021

michael-s-molina commented Apr 7, 2021 •

edited

Loading

codecov bot commented Apr 7, 2021 •

edited

Loading