fix(cross-filters): Make chart emitting cross-filter exclude itself from filtering #14046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14046 +/- ##
=======================================
Coverage 79.12% 79.12%
=======================================
Files 938 938
Lines 47523 47523
Branches 5940 5940
=======================================
Hits 37604 37604
Misses 9793 9793
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
Apr 9, 2021
| @@ -92,7 +92,7 @@ export const getAllActiveFilters = ({ | |||
| const scope = nativeFilters?.[filterId]?.scope ?? | |||
| chartConfiguration?.[filterId]?.crossFilters?.scope ?? { | |||
| rootPath: [DASHBOARD_ROOT_ID], | |||
| excluded: [], | |||
| excluded: [filterId], | |||
There was a problem hiding this comment.
Is there risk that chartConfiguration[filterId].crossFilters.scope.excluded == [], in which case the filter won't exclude itself?
There was a problem hiding this comment.
I haven't encountered such case. It's either an empty object or an array with a chart ID.
villebro
approved these changes
Apr 12, 2021
amitmiran137
pushed a commit
that referenced
this pull request
Apr 13, 2021
* master: fix: unable to apply logging format (#14074) refactor: Bootstrap to AntD - Slider (#13989) chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306) fix(listview): update listview feature flag (#13906) Add docs for configuring Docker Compose setup (#13961) feat: invalid password error message (Postgres) (#14038) fix: flacky test in test_update_dataset_item_w_override_columns (#14082) feat: Implement Celery SoftTimeLimit handling (#13740) feat: only send alert error emails to owners of the alert (#13862) feat: add descriptions to report emails (#13827) Make chart exclude itself from cross filtering (#14046) fix: fix bug when remove chart not removing it's related cross filter data (#14081) feat(native-filters): Add default first value to select filter (#13726) feat: Make async query JWT cookie domain configurable (#14007) fix: add exception to catch session not having JWT (#14036) # Conflicts: # superset-frontend/src/dashboard/actions/hydrate.js # superset/views/core.py
amitmiran137
pushed a commit
that referenced
this pull request
Apr 13, 2021
* master: (53 commits) test: Adds tests to the UndoRedoKeyListeners component (#13919) chore: Adds dataMask reducer to reducerIndex (#13951) test: Tests audit for the Dashboard FilterBar (#13916) fix: unable to apply logging format (#14074) refactor: Bootstrap to AntD - Slider (#13989) chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306) fix(listview): update listview feature flag (#13906) Add docs for configuring Docker Compose setup (#13961) feat: invalid password error message (Postgres) (#14038) fix: flacky test in test_update_dataset_item_w_override_columns (#14082) feat: Implement Celery SoftTimeLimit handling (#13740) feat: only send alert error emails to owners of the alert (#13862) feat: add descriptions to report emails (#13827) Make chart exclude itself from cross filtering (#14046) fix: fix bug when remove chart not removing it's related cross filter data (#14081) feat(native-filters): Add default first value to select filter (#13726) feat: Make async query JWT cookie domain configurable (#14007) fix: add exception to catch session not having JWT (#14036) Use consistent chart value (#14031) fix: Use superset generic db to catch external_metadata queries (#13974) ...
junlincc
added
the
dashboard:cross-filters
junlincc
changed the title
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a chart emits cross-filter, the filter is applied to the chart-emitter. The result is that the user cannot add another value to that filter, because every value other than the current filter had been filtered out. This PR prevents the chart from applying a filter to itself, by adding it's ID to
excludedarray.To test, enable the flag
DASHBOARD_CROSS_FILTERS, go to USA Birth Names dashboard (from sample data), enable cross filtering for pie chart and try to emit a cross filter.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/15073128/114161279-2b5a1e80-9928-11eb-9c1d-451519753e20.mov
After:
https://user-images.githubusercontent.com/15073128/114161311-33b25980-9928-11eb-907e-9cfd14c32eca.mov
CC: @villebro @junlincc
TEST PLAN
ADDITIONAL INFORMATION