Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds dataMask reducer to reducerIndex #13951

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds dataMask reducer to reducerIndex.

TEST PLAN

1 - Execute all tests
2 - All tests should pass

@rusackas

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #13951 (679913e) into master (e062906) will decrease coverage by 0.20%.
The diff coverage is n/a.

❗ Current head 679913e differs from pull request most recent head a4d1d2b. Consider uploading reports for the commit a4d1d2b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13951      +/-   ##
==========================================
- Coverage   78.08%   77.87%   -0.21%     
==========================================
  Files         934      939       +5     
  Lines       47352    47550     +198     
  Branches     5952     5996      +44     
==========================================
+ Hits        36976    37031      +55     
- Misses      10232    10377     +145     
+ Partials      144      142       -2     
Flag Coverage Δ
cypress 56.05% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/components/controls/CollectionControl.jsx 21.21% <0.00%> (-24.25%) ⬇️
...components/controls/FilterBoxItemControl/index.jsx 13.20% <0.00%> (ø)
...-frontend/src/common/components/Dropdown/index.tsx 100.00% <0.00%> (ø)
...re/components/controls/CollectionControl/index.jsx 45.45% <0.00%> (ø)
...end/src/common/components/DropdownButton/index.tsx 9.52% <0.00%> (ø)
...ponents/controls/TimeSeriesColumnControl/index.jsx 11.76% <0.00%> (ø)
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.61% <0.00%> (+0.32%) ⬆️
...set-frontend/src/dashboard/util/getDropPosition.js 92.42% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e062906...a4d1d2b. Read the comment docs.

@rusackas rusackas merged commit 55257ab into apache:master Apr 13, 2021
amitmiran137 pushed a commit that referenced this pull request Apr 13, 2021
* master: (53 commits)
  test: Adds tests to the UndoRedoKeyListeners component (#13919)
  chore: Adds dataMask reducer to reducerIndex (#13951)
  test: Tests audit for the Dashboard FilterBar (#13916)
  fix: unable to apply logging format (#14074)
  refactor: Bootstrap to AntD - Slider (#13989)
  chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306)
  fix(listview): update listview feature flag (#13906)
  Add docs for configuring Docker Compose setup (#13961)
  feat: invalid password error message (Postgres) (#14038)
  fix: flacky test in test_update_dataset_item_w_override_columns (#14082)
  feat: Implement Celery SoftTimeLimit handling (#13740)
  feat: only send alert error emails to owners of the alert (#13862)
  feat: add descriptions to report emails (#13827)
  Make chart exclude itself from cross filtering (#14046)
  fix: fix bug when remove chart not  removing it's related cross filter data (#14081)
  feat(native-filters): Add default first value to select filter (#13726)
  feat: Make async query JWT cookie domain configurable (#14007)
  fix: add exception to catch session not having JWT (#14036)
  Use consistent chart value (#14031)
  fix: Use superset generic db to catch external_metadata queries (#13974)
  ...
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS test:component 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants