fix: unable to apply logging format #14074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14074 +/- ##
==========================================
+ Coverage 79.30% 79.55% +0.24%
==========================================
Files 939 942 +3
Lines 47541 47675 +134
Branches 5938 5980 +42
==========================================
+ Hits 37703 37926 +223
+ Misses 9717 9628 -89
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Great! Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
amitmiran137
pushed a commit
that referenced
this pull request
Apr 13, 2021
* master: fix: unable to apply logging format (#14074) refactor: Bootstrap to AntD - Slider (#13989) chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306) fix(listview): update listview feature flag (#13906) Add docs for configuring Docker Compose setup (#13961) feat: invalid password error message (Postgres) (#14038) fix: flacky test in test_update_dataset_item_w_override_columns (#14082) feat: Implement Celery SoftTimeLimit handling (#13740) feat: only send alert error emails to owners of the alert (#13862) feat: add descriptions to report emails (#13827) Make chart exclude itself from cross filtering (#14046) fix: fix bug when remove chart not removing it's related cross filter data (#14081) feat(native-filters): Add default first value to select filter (#13726) feat: Make async query JWT cookie domain configurable (#14007) fix: add exception to catch session not having JWT (#14036) # Conflicts: # superset-frontend/src/dashboard/actions/hydrate.js # superset/views/core.py
amitmiran137
pushed a commit
that referenced
this pull request
Apr 13, 2021
* master: (53 commits) test: Adds tests to the UndoRedoKeyListeners component (#13919) chore: Adds dataMask reducer to reducerIndex (#13951) test: Tests audit for the Dashboard FilterBar (#13916) fix: unable to apply logging format (#14074) refactor: Bootstrap to AntD - Slider (#13989) chore(spa refactor): refactoring dashboard to use api's instead of bootstrapdata (#13306) fix(listview): update listview feature flag (#13906) Add docs for configuring Docker Compose setup (#13961) feat: invalid password error message (Postgres) (#14038) fix: flacky test in test_update_dataset_item_w_override_columns (#14082) feat: Implement Celery SoftTimeLimit handling (#13740) feat: only send alert error emails to owners of the alert (#13862) feat: add descriptions to report emails (#13827) Make chart exclude itself from cross filtering (#14046) fix: fix bug when remove chart not removing it's related cross filter data (#14081) feat(native-filters): Add default first value to select filter (#13726) feat: Make async query JWT cookie domain configurable (#14007) fix: add exception to catch session not having JWT (#14036) Use consistent chart value (#14031) fix: Use superset generic db to catch external_metadata queries (#13974) ...
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
* fix: unable to apply logging format * Update superset/app.py Great! Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix: unable to apply logging format * Update superset/app.py Great! Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Now the Python logging formatter does not apply correctly. This is because there was already
root loggerhander before this code was executed.superset/superset/utils/logging_configurator.py
Lines 54 to 55 in a4fd6b8
There are two ways to solve this problem.
forceargument tologging.basicConfig. https://docs.python.org/3/library/logging.html#logging.basicConfigThis PR uses the first.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
Tested in my local laptop.
ADDITIONAL INFORMATION