go/python: members with same name but different capitalization result in duplicate declarations

[eladb]

🐛 Bug Report

Affected Languages

• Python (second method overrides first)
• Golang

General Information

• JSII Version: 1.18.0
• Platform: all

What is the problem?

If a class has two methods with the same name but slightly different capitalization, the go code generator may end up with the same method name and eventually result in a duplicate definition error.

For example, in CDK8s, we had the following:

  public toIsoString(): string { ... }

  /** @deprecated */
  public toISOString(): string { ... }

This resulted in the following error during jsii-pacmak:

# github.com/awslabs/cdk8s-go/cdk8s/cdk8s
./cdk8s.go:1074:2: duplicate method ToIsoString
./cdk8s.go:1237:20: (*Duration).ToIsoString redeclared in this block
 	previous declaration at ./cdk8s.go:1224:6

[eladb]

This is technically blocking the release of CDK for Go since the Duration class has two methods with the same name toIsoString() and toISOString(), but I think it might be okay to break this API since this method has been deprecated for ages.

[eladb]

This also happens in Python albeit does not produce an error during build and the methods just override each other.

The Duration.to_iso_string() method is indicated to be "deprecated", but there is actually a non-deprecated toIsoString() method which is not accessible.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.