go: nested class names can conflict with top-level names

[eladb]

🐛 Bug Report

Affected Languages

• GoLang
• TypeScript or Javascript
• Python
• Java
• .NET (C#, F#, ...)

General Information

• JSII Version: 1.24.0
• Platform: any

What is the problem?

Consider the following jsii code (widely used in the CDK L1 generated output):

export interface CfnBrokerProps {
  readonly tags?: CfnBroker.TagsEntryProperty[];
}

export namespace CfnBroker {
  export interface TagsEntryProperty {
    readonly key: string;
    readonly value: string;
  }
}

This will result in the following go output:

// duplicate-names
package duplicatenames


type CfnBrokerProps struct {
	Tags []cfnbroker.TagsEntryProperty `json:"tags"`
}

If I would add a class to my jsii code, e.g:

export class FooBar {
  public brokerTags?: CfnBroker.TagsEntryProperty;
}

Then, the imports are added.

[eladb]

Fixed by #2650

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.