go: namespaces with the same name as a class are broken

[eladb]

🐛 Bug Report

Affected Languages

• GoLang
• TypeScript or Javascript
• Python
• Java
• .NET (C#, F#, ...)

General Information

• JSII Version: 1.24.0
• Platform: any

What is the problem?

Consider the following jsii code:

export class Namespace1 {
  public foo() {
    return;
  }
}

export class Namespace2 {
  public foo() {
    return;
  }
}

export namespace Namespace1 {
  export interface Foo {
    readonly bar: string;
  }
}

export namespace Namespace2 {
  export interface Foo {
    readonly baz: string;
    readonly bug: number;
  }
}

The go output does not treat the namespaces as submodules and results in duplicate Foo type:

./duplicatenames.go:79:6: Foo redeclared in this block
        previous declaration at ./duplicatenames.go:42:6

The go output looks like this:

// duplicate-names
package duplicatenames

import (
	_jsii_ "github.com/aws/jsii-runtime-go"
	_init_ "github.com/foo/bar/duplicatenames/jsii"
)

type Namespace1 interface {
	Foo()
}

// The jsii proxy struct for Namespace1
type namespace1_jsiiProxy struct {
	_ byte // padding
}

func NewNamespace1() Namespace1 {
	_init_.Initialize()

	n := namespace1_jsiiProxy{}

	_jsii_.Create(
		"duplicate-names.Namespace1",
		nil /* no parameters */,
		[]_jsii_.FQN{},
		nil, // no overrides
		&n,
	)

	return &n
}

func (n *namespace1_jsiiProxy) Foo() {
	_jsii_.InvokeVoid(
		n,
		"foo",
		nil /* no parameters */,
	)
}

type Foo struct {
	Bar string `json:"bar"`
}

type Namespace2 interface {
	Foo()
}

// The jsii proxy struct for Namespace2
type namespace2_jsiiProxy struct {
	_ byte // padding
}

func NewNamespace2() Namespace2 {
	_init_.Initialize()

	n := namespace2_jsiiProxy{}

	_jsii_.Create(
		"duplicate-names.Namespace2",
		nil /* no parameters */,
		[]_jsii_.FQN{},
		nil, // no overrides
		&n,
	)

	return &n
}

func (n *namespace2_jsiiProxy) Foo() {
	_jsii_.InvokeVoid(
		n,
		"foo",
		nil /* no parameters */,
	)
}

type Foo struct {
	Baz string `json:"baz"`
	Bug float64 `json:"bug"`
}

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.